Page MenuHomeFreeBSD

diff3: fix diff3 -A
ClosedPublic

Authored by bapt on Fri, Feb 13, 8:49 AM.
Tags
None
Referenced Files
F144932190: D55276.id171860.diff
Sat, Feb 14, 6:13 AM
Unknown Object (File)
Fri, Feb 13, 10:42 AM
Unknown Object (File)
Fri, Feb 13, 10:01 AM
Subscribers

Details

Summary

for cases where file2 differs but file1 and file3 agrees, the code
stored the file2 and file3 line numbers in the de[] editing script
entries but used them as if they were file1 line numbers.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bapt requested review of this revision.Fri, Feb 13, 8:49 AM

This looks ok, but I will have to admit that diff3 was always a bit of a mystery box. Please update the comment, but assuming tests don't start failing I'm willing to bet this is an improvement.

usr.bin/diff3/diff3.c
884

This comment is out of date now.

This revision is now accepted and ready to land.Fri, Feb 13, 9:12 AM
This revision was automatically updated to reflect the committed changes.