Page MenuHomeFreeBSD
Differential D55260

ipfilter: Avoid negative array indicies
ClosedPublic
Actions

Authored by cy on Feb 12 2026, 4:14 AM.
Tags
None
Referenced Files
F156659916: D55260.id172040.diff
Fri, May 15, 11:50 AM
Unknown Object (File)
Thu, May 14, 12:37 PM
Unknown Object (File)
Wed, May 13, 4:18 PM
Unknown Object (File)
Sun, May 10, 8:00 AM
Unknown Object (File)
Sun, May 10, 8:00 AM
Unknown Object (File)
Sat, May 9, 5:35 PM
Unknown Object (File)
Sat, May 9, 5:26 PM
Unknown Object (File)
Tue, Apr 28, 9:31 AM
View All 29 Files
Subscribers
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
emaste
markj
glebius
Commits
rG3fdbd8a07a2d: ipfilter: Avoid negative array indicies
Summary

Array indices must always be posive. We avoid this by making each index
unsigned. This mitigates out-of-bounds reads and writes.

Reported by: Ilja Van Sprundel <ivansprundel@ioactive.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
netpfil/
ipfilter/
netinet/
4 lines
2 lines
2 lines

Diff 172040

View Options

sys/netpfil/ipfilter/netinet/fil.c

Loading...
View Options

sys/netpfil/ipfilter/netinet/ip_fil.h

Loading...
View Options

sys/netpfil/ipfilter/netinet/ip_state.c

Loading...