heimdal: Pass the correct pointer to realloc when growing a string buffer

[jhb]

Summary

The realloc in my_fgetln was trying to grow the pointer to the string
buffer, not the string buffer itself.

In function 'my_fgetln',

inlined from 'mit_prop_dump' at crypto/heimdal/kdc/mit_dump.c:156:19:

crypto/heimdal/kdc/mit_dump.c:119:13: error: 'realloc' called on unallocated object 'line' [-Werror=free-nonheap-object]

119 |         n = realloc(buf, *sz + (*sz >> 1));
    |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

crypto/heimdal/kdc/mit_dump.c: In function 'mit_prop_dump':
crypto/heimdal/kdc/mit_dump.c:139:11: note: declared here

139 |     char *line = NULL;
    |           ^~~~

[rmacklem]

I know nothing about gcc flags, but if it gets
rid of the error, that seems fine to me.

[jhb]

Oh, I misread the code. There is a real bug here. It is calling realloc on the wrong thing. I will upload a new diff in a sec.

[jhb]

Fix the bug