Differential D54738

arm64/vmm: Simplify vmmpmap_remove()
ClosedPublic
Actions

Authored by markj on Fri, Jan 16, 4:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Feb 10, 10:21 AM

	Unknown Object (File)
	Mon, Feb 9, 6:33 PM

	Unknown Object (File)
	Sun, Jan 25, 11:21 AM

	Unknown Object (File)
	Sun, Jan 25, 6:40 AM

	Unknown Object (File)
	Sat, Jan 24, 9:40 PM

	Unknown Object (File)
	Thu, Jan 22, 3:32 AM

	Unknown Object (File)
	Wed, Jan 21, 4:32 AM

	Unknown Object (File)
	Mon, Jan 19, 3:55 AM

View All 14 Files

Subscribers

Details

Reviewers

andrew
manu

Group Reviewers

Commits

rG2ca0b727d0f2: arm64/vmm: Simplify vmmpmap_remove()
rG31e5decb18a6: arm64/vmm: Simplify vmmpmap_remove()

Summary

This function handles invalid intermediate PTP entries, but there's no
reason for this: the passed range should be mapped. In particular, we
assert that all L3 entries encountered are mapped. So let's simplify
the code a bit. No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Fri, Jan 16, 4:06 PM

Herald added a reviewer: manu. · View Herald TranscriptFri, Jan 16, 4:06 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

markj requested review of this revision.Fri, Jan 16, 4:06 PM

Harbormaster completed remote builds in B69923: Diff 169852.Fri, Jan 16, 4:06 PM

andrew accepted this revision.Mon, Jan 19, 12:31 PM

This revision is now accepted and ready to land.Mon, Jan 19, 12:31 PM

Closed by commit rG31e5decb18a6: arm64/vmm: Simplify vmmpmap_remove() (authored by markj). · Explain WhyMon, Jan 26, 10:05 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG31e5decb18a6: arm64/vmm: Simplify vmmpmap_remove().

markj added a commit: rG2ca0b727d0f2: arm64/vmm: Simplify vmmpmap_remove().Mon, Feb 9, 6:11 PM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

vmm/

27 lines

Diff 170501

sys/arm64/vmm/vmm_mmu.c

Loading...