Page MenuHomeFreeBSD

ipfilter: Interface name must not extend beyond end of buffer
Needs ReviewPublic

Authored by cy on Jan 8 2026, 8:59 PM.
Tags
None
Referenced Files
F174894687: D54607.id169346.diff
Tue, Oct 6, 7:58 PM
Unknown Object (File)
Sun, Oct 4, 7:49 PM
Unknown Object (File)
Sun, Oct 4, 5:49 AM
Unknown Object (File)
Sat, Oct 3, 7:05 PM
Unknown Object (File)
Sat, Oct 3, 11:11 AM
Unknown Object (File)
Fri, Oct 2, 2:59 AM
Unknown Object (File)
Sat, Sep 26, 7:53 PM
Unknown Object (File)
Thu, Sep 24, 6:19 AM

Details

Summary

sifpidx (an interface name) cannot extend beyond the end of the
fr_names buffer.
We do the validation for fr_sifpidx here because it is a union that
contains an offset only when fr_sifpidx points to an interface name,
an offset into fr_names. The union is an offset into fr_names in this
case only.

Note that sifpidx is only used in ipf_sync() which implments ipf -y.

Reported by: Ilja Van Sprundel <ivansprundel@ioactive.com>
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69739
Build 66622: arc lint + arc unit