Fix missing brackets in e1000_phy.c
ClosedPublic
Actions

Authored by jim_netgate.com on Feb 25 2016, 8:32 PM.

Details

Reviewers

erj
gnn
sbruno

Group Reviewers

Intel Networking

Commits

rS296385: The register read/write mphy functions have misleading whitespace around

Summary

The register read/write mphy functions have misleading whitespace around the locked check. This cleanup merely preserves the existing functionality while improving the ready check.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2659
Build 2678: arc lint + arc unit

Event Timeline

jim_netgate.com updated this revision to Diff 13742.Feb 25 2016, 8:32 PM

jim_netgate.com retitled this revision from to Fix missing brackets in e1000_phy.c.

jim_netgate.com updated this object.

jim_netgate.com edited the test plan for this revision. (Show Details)

jim_netgate.com added reviewers: gnn, erj.

Herald added reviewers: sbruno, Intel Networking. · View Herald TranscriptFeb 25 2016, 8:32 PM

Herald added a subscriber: imp. · View Herald Transcript

gnn accepted this revision.Feb 25 2016, 9:25 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.Feb 25 2016, 9:25 PM

subtle braces are subtle.

stlgtm

erj accepted this revision.Feb 26 2016, 1:15 AM

erj edited edge metadata.

Closed by commit rS296385: The register read/write mphy functions have misleading whitespace around (authored by sbruno). · Explain WhyMar 4 2016, 2:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

e1000_phy.c

14 lines

Diff 13742

View Options

Fix missing brackets in e1000_phy.cClosedPublicActions