Page MenuHomeFreeBSD

makefs: tests: Fix timestamp-related tests
ClosedPublic

Authored by jlduran on Wed, Dec 31, 1:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jan 10, 5:03 PM
Unknown Object (File)
Sat, Jan 10, 3:30 PM
Unknown Object (File)
Sat, Jan 10, 4:39 AM
Unknown Object (File)
Fri, Jan 9, 7:37 PM
Unknown Object (File)
Fri, Jan 9, 2:55 PM
Unknown Object (File)
Thu, Jan 8, 8:06 PM
Unknown Object (File)
Thu, Jan 8, 3:48 PM
Unknown Object (File)
Tue, Jan 6, 11:01 AM
Subscribers

Details

Summary

Use a variable for mtree that includes the DEFAULT_MTREE_KEYWORDS, in
order to avoid missing the important "time" keyword.

Unskip the "failing" tests, and comment out the specific failing checks,
these will be addressed (or at least discussed) in a different revision.

For MS-DOS tests, use an even value timestamp, as precision is 2s.

For ZFS tests, use import_image instead of mount_image consistently.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
usr.sbin/makefs/tests/makefs_zfs_tests.sh
964

These options are all redundant, i.e., atf_check will verify them by default. Generally I omit them on purpose to make test code a bit neater. But I guess it's better to be consistent with other tests of the same type.

This revision is now accepted and ready to land.Thu, Jan 1, 3:19 PM
bnovkov added inline comments.
usr.sbin/makefs/tests/makefs_cd9660_tests.sh
40

I would consider moving the MTREE variable definition to makefs_tests_common.sh since all its contents are the same in all three scripts, but I won't insist.

jlduran added inline comments.
usr.sbin/makefs/tests/makefs_cd9660_tests.sh
40

Yes! It will be addressed upon commit.

usr.sbin/makefs/tests/makefs_zfs_tests.sh
964

I agree, and I'll try to address this suggestion in D54427; however, there is a high probability it may not be accepted.

This revision was automatically updated to reflect the committed changes.
jlduran marked an inline comment as done.