Page MenuHomeFreeBSD
Differential D54424

makefs: tests: Extend the timeout of ZFS compression test
AcceptedPublic
Actions

Authored by jlduran on Wed, Dec 31, 1:37 AM.
Tags
None
Referenced Files
F141107596: D54424.diff
Wed, Dec 31, 11:17 PM
F141087344: D54424.id.diff
Wed, Dec 31, 4:59 PM
F141066676: D54424.id168786.diff
Wed, Dec 31, 10:53 AM
F141063286: D54424.id.diff
Wed, Dec 31, 9:47 AM
F141058569: D54424.id168786.diff
Wed, Dec 31, 8:13 AM
Subscribers
asomers
imp
ngie

Details

Reviewers
asomers
Group Reviewers
tests
Summary

The test makefs_zfs_tests:compression is timing out on ci.freebsd.org.
Increase the default timeout to allow it to finish.

While here, check if the file exists before cleaning up, otherwise, cat
may fail.

Reported by: Jenkins

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 69534
Build 66417: arc lint + arc unit

Event Timeline

jlduran created this revision.Wed, Dec 31, 1:37 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Dec 31, 1:37 AM
jlduran requested review of this revision.Wed, Dec 31, 1:37 AM
Harbormaster completed remote builds in B69534: Diff 168786.Wed, Dec 31, 1:37 AM
jlduran added a child revision: D54425: makefs: tests: Extend the timeout of ZFS file_extend test.Wed, Dec 31, 1:38 AM
jlduran added a comment.EditedWed, Dec 31, 1:43 AM

There is really no way to tell beforehand if this timeout is enough.
Reference: https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1867/testReport/junit/usr.sbin.makefs/makefs_zfs_tests/compression/

jlduran added a reviewer: tests.Wed, Dec 31, 1:44 AM
asomers accepted this revision.Wed, Dec 31, 3:30 PM
asomers added a subscriber: asomers.

This looks fine. But as the default timeout is already 300s, I suggest increasing it even more. If it were me, I would double it.

This revision is now accepted and ready to land.Wed, Dec 31, 3:30 PM
jlduran added a comment.Wed, Dec 31, 3:51 PM
In D54424#1243918, @asomers wrote:

This looks fine. But as the default timeout is already 300s, I suggest increasing it even more. If it were me, I would double it.

Thank you, I'll double the amount of time (600s) upon commit.

ngie added a subscriber: ngie.EditedThu, Jan 1, 12:11 AM
This comment has been deleted.
usr.sbin/makefs/tests/makefs_zfs_tests.sh
137–138

Is a bug filed for this issue? Have we been close to hitting the default limit for a while? This failure might hint at a problem with ZFS on main if the test hasn't been around for a while.

Revision Contents
Changeset List

PathSize
usr.sbin/
makefs/
tests/
22 lines

Diff 168786

View Options

usr.sbin/makefs/tests/makefs_zfs_tests.sh

Loading...