makefs: tests: Double the timeout of ZFS compression test
ClosedPublic
Actions

Authored by jlduran on Wed, Dec 31, 1:37 AM.

Details

Reviewers

Group Reviewers

Commits

rGf8b5a8a97743: makefs: tests: Double the timeout of ZFS compression test
rG9f28e92637e9: makefs: tests: Double the timeout of ZFS compression test

Summary

The test makefs_zfs_tests:compression is timing out on ci.freebsd.org.
Double the default timeout to allow it to finish.

While here, check if the file exists before cleaning up, otherwise, cat
may fail.

Reported by: Jenkins

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran created this revision.Wed, Dec 31, 1:37 AM

Herald added a subscriber: imp. · View Herald TranscriptWed, Dec 31, 1:37 AM

jlduran requested review of this revision.Wed, Dec 31, 1:37 AM

Harbormaster completed remote builds in B69534: Diff 168786.Wed, Dec 31, 1:37 AM

jlduran added a child revision: D54425: makefs: tests: Double the timeout of ZFS file_extend test.Wed, Dec 31, 1:38 AM

There is really no way to tell beforehand if this timeout is enough.
Reference: https://ci.freebsd.org/view/Test/job/FreeBSD-main-aarch64-test/1867/testReport/junit/usr.sbin.makefs/makefs_zfs_tests/compression/

jlduran added a reviewer: tests.Wed, Dec 31, 1:44 AM

This looks fine. But as the default timeout is already 300s, I suggest increasing it even more. If it were me, I would double it.

This revision is now accepted and ready to land.Wed, Dec 31, 3:30 PM

In D54424#1243918, @asomers wrote:

This looks fine. But as the default timeout is already 300s, I suggest increasing it even more. If it were me, I would double it.

Thank you, I'll double the amount of time (600s) upon commit.

This comment has been deleted.

usr.sbin/makefs/tests/makefs_zfs_tests.sh
137–138	Is a bug filed for this issue? Have we been close to hitting the default limit for a while? This failure might hint at a problem with ZFS on main if the test hasn't been around for a while.

jlduran retitled this revision from makefs: tests: Extend the timeout of ZFS compression test to makefs: tests: Double the timeout of ZFS compression test.Fri, Jan 2, 8:23 PM

jlduran edited the summary of this revision. (Show Details)

jlduran added inline comments.Fri, Jan 2, 8:48 PM

usr.sbin/makefs/tests/makefs_zfs_tests.sh
137–138	Is a bug filed for this issue? I did not see any bug filed after a quick search. Have we been close to hitting the default limit for a while? I think I understand what you mean, yes the test sometimes pass: ~220s (for example), sometimes barely making the cutoff. The tests occasionally timeout only when ran on an emulated architecture, on amd64, they finish perfectly on time. No drastic increase in the time has been historically seen, as to presume a regression in ZFS itself.