Page MenuHomeFreeBSD
Differential D53859

sound: Retire snd_mixer->busy
ClosedPublic
Actions

Authored by christos on Fri, Nov 21, 5:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 8, 8:13 AM
Unknown Object (File)
Thu, Dec 4, 7:34 AM
Unknown Object (File)
Wed, Dec 3, 6:56 AM
Unknown Object (File)
Sun, Nov 30, 2:28 PM
Unknown Object (File)
Sat, Nov 29, 1:24 PM
Unknown Object (File)
Thu, Nov 27, 10:41 PM
Unknown Object (File)
Wed, Nov 26, 7:28 PM
Unknown Object (File)
Sun, Nov 23, 11:53 AM
View All 16 Files
Subscribers
imp

Details

Reviewers
markj
emaste
kib
Commits
rG26365bf2516f: sound: Retire snd_mixer->busy
rGe5d50a679aa1: sound: Retire snd_mixer->busy
Summary

Does not really serve any real purpose. It gets set on mixer_open() and
unset on mixer_close(), so it essentially tells us whether the mixer is
open or not.

mixer_close() uses it to return EBADF in case the mixer is not busied,
as in, the mixer has not been open()'d yet. This is redundant. The other
place where this is used is to decide whether to serve an ioctl issued
by userland, in which case it won't if, again, the mixer has not been
busied (i.e., opened). Again, seems redundant.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68785
Build 65668: arc lint + arc unit

Event Timeline

christos created this revision.Fri, Nov 21, 5:05 PM
Herald added a subscriber: imp. · View Herald TranscriptFri, Nov 21, 5:05 PM
christos requested review of this revision.Fri, Nov 21, 5:05 PM
Harbormaster completed remote builds in B68785: Diff 166912.Fri, Nov 21, 5:05 PM
markj accepted this revision.Fri, Nov 28, 2:03 PM
markj added inline comments.
sys/dev/sound/pci/es137x.c
1543

Was the busy state just getting leaked here?

This revision is now accepted and ready to land.Fri, Nov 28, 2:03 PM
christos added inline comments.Fri, Nov 28, 2:31 PM
sys/dev/sound/pci/es137x.c
1543

I don't think so. The busy state was set in mixer_open() (i.e., open(2) for /dev/mixer), and cleared in mixer_close().

Closed by commit rGe5d50a679aa1: sound: Retire snd_mixer->busy (authored by christos). · Explain WhyFri, Nov 28, 2:36 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rGe5d50a679aa1: sound: Retire snd_mixer->busy.
christos added a commit: rG26365bf2516f: sound: Retire snd_mixer->busy.Sat, Dec 6, 1:36 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pci/
4 lines
pcm/
2 lines
30 lines

Diff 166912

View Options

sys/dev/sound/pci/es137x.c

Loading...
View Options

sys/dev/sound/pcm/mixer.h

Loading...
View Options

sys/dev/sound/pcm/mixer.c

Loading...