Page MenuHomeFreeBSD
Differential D53821

sys/_types.h: add void * to __max_align_t
ClosedPublic
Actions

Authored by brooks on Wed, Nov 19, 11:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 12, 4:59 PM
Unknown Object (File)
Wed, Dec 3, 2:36 AM
Unknown Object (File)
Mon, Dec 1, 11:38 AM
Unknown Object (File)
Sun, Nov 30, 2:35 AM
Unknown Object (File)
Wed, Nov 26, 7:51 PM
Unknown Object (File)
Thu, Nov 20, 11:19 PM
Unknown Object (File)
Thu, Nov 20, 11:19 PM
Unknown Object (File)
Thu, Nov 20, 11:09 PM
View All 17 Files
Subscribers
None

Details

Reviewers
imp
kib
Group Reviewers
cheri
Commits
rG528e70a12ca6: sys/_types.h: add void * to __max_align_t
Summary

Add a pointer member to __max_align_t as pointers may have different
alignment requirements than long long or long double.

Effort: CHERI upstreaming
Sponsored by: Innovate UK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 68729
Build 65612: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Wed, Nov 19, 11:18 AM
brooks created this revision.
brooks added a parent revision: D53820: sys/_types.h: define fallback __(u)intcap_t.
Harbormaster completed remote builds in B68729: Diff 166754.Wed, Nov 19, 11:18 AM
brooks added a child revision: D53822: sys/_types.h: add __intptr_t to __mbstate_t.Wed, Nov 19, 11:18 AM
kib accepted this revision.Wed, Nov 19, 1:51 PM
kib added inline comments.
sys/sys/_types.h
204

Should this be long double?

This revision is now accepted and ready to land.Wed, Nov 19, 1:51 PM
brooks added inline comments.Wed, Nov 19, 2:09 PM
sys/sys/_types.h
204

Indeed, that's quite odd. Clang's version uses long double. I'm also not sure why the alignment attributes are used at all since structures members are going to be naturally aligned regardless.

kib added inline comments.Wed, Nov 19, 2:50 PM
sys/sys/_types.h
204

Might be it is a counter-measure against #pragma packed() around it.

I will post a review to change to long double.

Closed by commit rG528e70a12ca6: sys/_types.h: add void * to __max_align_t (authored by brooks). · Explain WhyThu, Nov 27, 2:57 PM
This revision was automatically updated to reflect the committed changes.
brooks added a commit: rG528e70a12ca6: sys/_types.h: add void * to __max_align_t.

Revision Contents
Changeset List

PathSize
sys/
sys/
1 line

Diff 166754

View Options

sys/sys/_types.h

Loading...