release: Don't try to fetch distfiles for pkgbase
ClosedPublic
Actions

Authored by cperciva on Mon, Nov 3, 9:46 PM.

Details

Reviewers

ivy
emaste
ziaee

Commits

rG05b3a45cd065: release: Don't try to fetch distfiles for pkgbase

Summary

In order to comply with the require that GCE images must include their
source code, we fetch distfiles for all of the packages installed into
GCE images. This fails for obvious reasons for packages with an origin
of base/*; filter those out to generate the list to fetch.

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva created this revision.Mon, Nov 3, 9:46 PM

Herald added subscribers: jrtc27, imp. · View Herald TranscriptMon, Nov 3, 9:46 PM

cperciva requested review of this revision.Mon, Nov 3, 9:46 PM

Harbormaster completed remote builds in B68393: Diff 165770.Mon, Nov 3, 9:46 PM

cperciva added a parent revision: D53567: release: GCE builds depend on ftp.Mon, Nov 3, 9:46 PM

cperciva added a child revision: D53569: release: Make fetch happen in GCE images.

ivy accepted this revision.Tue, Nov 4, 12:21 AM

ivy added inline comments.

release/tools/gce.conf
103	you could use this instead: `pkg query -e '%o !~ base/*' '%o'`. i think it's a bit neater to use pkg's built-in functionality, but i don't feel very strongly about it.

This revision is now accepted and ready to land.Tue, Nov 4, 12:21 AM

cperciva added inline comments.Tue, Nov 4, 12:35 AM

release/tools/gce.conf
103	I agree it's neater, but I wanted something which was obviously right rather than needing a man page to be consulted. ;-) This will all need to be rewritten for 16 anyway since we're not going to have dist sets.