Page MenuHomeFreeBSD
Differential D53558

sound: Remove unnecessary initializations in feeder_create()
ClosedPublic
Actions

Authored by christos on Nov 3 2025, 3:31 PM.
Tags
None
Referenced Files
F174460294: D53558.id166221.diff
Sat, Oct 3, 10:39 AM
Unknown Object (File)
Tue, Sep 29, 6:48 PM
Unknown Object (File)
Tue, Sep 29, 4:37 PM
Unknown Object (File)
Wed, Sep 16, 12:45 PM
Unknown Object (File)
Wed, Sep 9, 12:34 AM
Unknown Object (File)
Tue, Sep 8, 10:25 AM
Unknown Object (File)
Fri, Sep 4, 11:30 PM
Unknown Object (File)
Fri, Sep 4, 11:17 AM
View All Files
Subscribers
imp

Details

Reviewers
markj
emaste
Commits
rGad348a08586f: sound: Remove unnecessary initializations in feeder_create()
rG699fd108c50c: sound: Remove unnecessary initializations in feeder_create()
Summary

We do not need to zero out fields since the struct is allocated with
M_ZERO. Also we no longer need to have a special case for the root
feeder.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Nov 3 2025, 3:31 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 3 2025, 3:31 PM
christos requested review of this revision.Nov 3 2025, 3:31 PM
Harbormaster completed remote builds in B68382: Diff 165742.Nov 3 2025, 3:31 PM
christos added a parent revision: D53557: sound: Retire pcm_feederdesc->type.Nov 3 2025, 3:31 PM
christos added a child revision: D53559: sound: Retire unused feeder_printchain().
markj added inline comments.Nov 3 2025, 6:35 PM
sys/dev/sound/pcm/feeder.c
100

It doesn't seem nice to assume that FEEDER_ROOT == 0?

christos added inline comments.Nov 4 2025, 12:45 PM
sys/dev/sound/pcm/feeder.c
100

What do you mean?

markj accepted this revision.Nov 4 2025, 12:54 PM
markj added inline comments.
sys/dev/sound/pcm/feeder.c
100

I misread the change, never mind.

This revision is now accepted and ready to land.Nov 4 2025, 12:54 PM
Closed by commit rG699fd108c50c: sound: Remove unnecessary initializations in feeder_create() (authored by christos). · Explain WhyNov 11 2025, 12:08 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG699fd108c50c: sound: Remove unnecessary initializations in feeder_create().
christos added a commit: rGad348a08586f: sound: Remove unnecessary initializations in feeder_create().Nov 18 2025, 12:57 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pcm/
11 lines

Diff 166221

View Options

sys/dev/sound/pcm/feeder.c

Loading...