Page MenuHomeFreeBSD

sound: Retire feedertab_entry
ClosedPublic

Authored by christos on Nov 3 2025, 3:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 21, 2:55 PM
Unknown Object (File)
Fri, Jun 19, 8:35 PM
Unknown Object (File)
Thu, Jun 18, 8:02 AM
Unknown Object (File)
May 23 2026, 3:04 PM
Unknown Object (File)
May 20 2026, 2:34 PM
Unknown Object (File)
May 20 2026, 1:08 PM
Unknown Object (File)
May 19 2026, 10:46 PM
Unknown Object (File)
May 19 2026, 4:21 PM
Subscribers

Details

Summary

Have an SLIST of feeder_class directly. This way we simplify the code,
and also avoid the additional malloc()/free() for each entry.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/sound/pcm/feeder.c
44

How is this list locked?

71

This loop can be replaced by SLIST_INIT(&feedertab);

christos marked an inline comment as done.

Address Mark's comment.

sys/dev/sound/pcm/feeder.c
44

It isn't. This list is created once after sound.ko has been loaded, and destroyed on unload. There is no adding/removing in the meantime.

This revision is now accepted and ready to land.Nov 4 2025, 12:51 PM
This revision was automatically updated to reflect the committed changes.