release: Spell metalog_add_data conventionally
ClosedPublic
Actions

Authored by cperciva on Sun, Nov 2, 12:17 AM.

Details

Reviewers

Commits

rG40e50d6d198e: release: Spell metalog_add_data conventionally
rGc3a3af134668: release: Spell metalog_add_data conventionally

Summary

MFC after: 3 days
Fixes: f1995d6fc13f ("release: Prepare GCE cloudware images for building as non-root")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva created this revision.Sun, Nov 2, 12:17 AM

Herald added subscribers: ivy, jrtc27, imp. · View Herald TranscriptSun, Nov 2, 12:17 AM

cperciva requested review of this revision.Sun, Nov 2, 12:17 AM

Harbormaster completed remote builds in B68344: Diff 165658.Sun, Nov 2, 12:17 AM

Oops. :(

I can't check at the moment: is this not caught by the use of set -e in mk-vmimage.sh?

This revision is now accepted and ready to land.Sun, Nov 2, 12:35 AM

In D53530#1222071, @markj wrote:

Oops. :(

I can't check at the moment: is this not caught by the use of set -e in mk-vmimage.sh?

It is, and the build fails as a result. I knew the GCE build was failing but thought it was due to a different problem (missing packages) until I went looking in the log files.

Closed by commit rGc3a3af134668: release: Spell metalog_add_data conventionally (authored by cperciva). · Explain WhySun, Nov 2, 12:44 AM

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rGc3a3af134668: release: Spell metalog_add_data conventionally.

cperciva added a commit: rG40e50d6d198e: release: Spell metalog_add_data conventionally.Wed, Nov 5, 10:04 PM

Revision Contents
Changeset List

Path

Size

release/

tools/

gce.conf

2 lines

Diff 165660

View Options

release: Spell metalog_add_data conventionallyClosedPublicActions