Page MenuHomeFreeBSD
Differential D53530

release: Spell metalog_add_data conventionally
ClosedPublic
Actions

Authored by cperciva on Nov 2 2025, 12:17 AM.
Tags
None
Referenced Files
F162652016: D53530.diff
Wed, Jul 15, 10:49 AM
F162643612: D53530.diff
Wed, Jul 15, 8:47 AM
F162632489: D53530.diff
Wed, Jul 15, 6:53 AM
F162632488: D53530.diff
Wed, Jul 15, 6:53 AM
F162576756: D53530.id.diff
Tue, Jul 14, 5:28 PM
Unknown Object (File)
Thu, Jul 9, 11:11 PM
Unknown Object (File)
Thu, Jul 9, 9:31 PM
Unknown Object (File)
Mon, Jun 29, 9:12 PM
View All 67 Files
Subscribers
imp
ivy
jrtc27

Details

Reviewers
markj
Commits
rG0888e3266377: release: Spell metalog_add_data conventionally
rG40e50d6d198e: release: Spell metalog_add_data conventionally
rGc3a3af134668: release: Spell metalog_add_data conventionally
Summary

MFC after: 3 days
Fixes: f1995d6fc13f ("release: Prepare GCE cloudware images for building as non-root")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cperciva created this revision.Nov 2 2025, 12:17 AM
Herald added subscribers: ivy, jrtc27, imp. · View Herald TranscriptNov 2 2025, 12:17 AM
cperciva requested review of this revision.Nov 2 2025, 12:17 AM
Harbormaster completed remote builds in B68344: Diff 165658.Nov 2 2025, 12:17 AM
markj accepted this revision.Nov 2 2025, 12:35 AM

Oops. :(

I can't check at the moment: is this not caught by the use of set -e in mk-vmimage.sh?

This revision is now accepted and ready to land.Nov 2 2025, 12:35 AM
cperciva added a comment.Nov 2 2025, 12:42 AM
In D53530#1222071, @markj wrote:

Oops. :(

I can't check at the moment: is this not caught by the use of set -e in mk-vmimage.sh?

It is, and the build fails as a result. I knew the GCE build was failing but thought it was due to a different problem (missing packages) until I went looking in the log files.

Closed by commit rGc3a3af134668: release: Spell metalog_add_data conventionally (authored by cperciva). · Explain WhyNov 2 2025, 12:44 AM
This revision was automatically updated to reflect the committed changes.
cperciva added a commit: rGc3a3af134668: release: Spell metalog_add_data conventionally.
cperciva added a commit: rG40e50d6d198e: release: Spell metalog_add_data conventionally.Nov 5 2025, 10:04 PM
cperciva added a commit: rG0888e3266377: release: Spell metalog_add_data conventionally.Nov 6 2025, 11:12 PM

Revision Contents
Changeset List

PathSize
release/
tools/
2 lines

Diff 165660

View Options

release/tools/gce.conf

Loading...