thread_single(P_TOTAL_STOP): set single-threading thread runnable
Changes PlannedPublic
Actions

Authored by kib on Oct 20 2025, 8:32 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 6, 1:24 PM

	Unknown Object (File)
	Tue, Nov 25, 1:19 PM

	Unknown Object (File)
	Nov 16 2025, 9:30 PM

	Unknown Object (File)
	Nov 16 2025, 8:39 PM

	Unknown Object (File)
	Oct 30 2025, 2:16 PM

	Unknown Object (File)
	Oct 29 2025, 10:50 AM

	Unknown Object (File)
	Oct 29 2025, 8:22 AM

	Unknown Object (File)
	Oct 29 2025, 6:07 AM

Subscribers

Details

Reviewers

markj

Summary

as last resort in ast_suspend(), since we might be the last thread going
in suspended state and the single-threading thread already off the cpu.

Reported by:    pho

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Oct 20 2025, 8:32 AM

Herald added subscribers: olce, imp. · View Herald TranscriptOct 20 2025, 8:32 AM

kib requested review of this revision.Oct 20 2025, 8:32 AM

markj added inline comments.Oct 20 2025, 6:05 PM

sys/kern/kern_thread.c
535
538
549	For other stop types, thread_suspend_check() is responsible for waking up the initiator with thread_unsuspend_one(). Why do we not handle the ALLSTOP case in thread_suspend_check() too?

Too naive, unfortunately.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_thread.c

18 lines

Diff 164581

View Options

thread_single(P_TOTAL_STOP): set single-threading thread runnableChanges PlannedPublicActions