Page MenuHomeFreeBSD

thread_single(P_TOTAL_STOP): set single-threading thread runnable
Changes PlannedPublic

Authored by kib on Mon, Oct 20, 8:32 AM.
Tags
None
Referenced Files
F136254272: D53211.diff
Sun, Nov 16, 9:30 PM
F136245217: D53211.diff
Sun, Nov 16, 8:39 PM
Unknown Object (File)
Thu, Oct 30, 2:16 PM
Unknown Object (File)
Wed, Oct 29, 10:50 AM
Unknown Object (File)
Wed, Oct 29, 8:22 AM
Unknown Object (File)
Wed, Oct 29, 6:07 AM
Unknown Object (File)
Wed, Oct 29, 6:03 AM
Unknown Object (File)
Mon, Oct 27, 1:14 PM
Subscribers

Details

Reviewers
markj
Summary
as last resort in ast_suspend(), since we might be the last thread going
in suspended state and the single-threading thread already off the cpu.

Reported by:    pho

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Mon, Oct 20, 8:32 AM
sys/kern/kern_thread.c
535
538
549

For other stop types, thread_suspend_check() is responsible for waking up the initiator with thread_unsuspend_one(). Why do we not handle the ALLSTOP case in thread_suspend_check() too?

kib planned changes to this revision.Tue, Oct 21, 12:02 AM

Too naive, unfortunately.