Page MenuHomeFreeBSD

thread_single(P_TOTAL_STOP): set single-threading thread runnable
Changes PlannedPublic

Authored by kib on Mon, Oct 20, 8:32 AM.
Tags
None
Referenced Files
F133154766: D53211.id164581.diff
Thu, Oct 23, 11:31 AM
Unknown Object (File)
Mon, Oct 20, 4:02 PM
Unknown Object (File)
Mon, Oct 20, 12:08 PM
Unknown Object (File)
Mon, Oct 20, 11:29 AM
Unknown Object (File)
Mon, Oct 20, 11:20 AM
Unknown Object (File)
Mon, Oct 20, 11:06 AM
Subscribers

Details

Reviewers
markj
Summary
as last resort in ast_suspend(), since we might be the last thread going
in suspended state and the single-threading thread already off the cpu.

Reported by:    pho

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Mon, Oct 20, 8:32 AM
sys/kern/kern_thread.c
535
538
549

For other stop types, thread_suspend_check() is responsible for waking up the initiator with thread_unsuspend_one(). Why do we not handle the ALLSTOP case in thread_suspend_check() too?

kib planned changes to this revision.Tue, Oct 21, 12:02 AM

Too naive, unfortunately.