Makefile.inc1: Build source packages before sets
ClosedPublic
Actions

Authored by ivy on Mon, Oct 13, 6:26 PM.

Details

Reviewers

jrtc27
cperciva

Commits

rGf01adba1e2ac: Makefile.inc1: Build source packages before sets
rG3b5ec539beef: Makefile.inc1: Build source packages before sets
rGea5685ba79fc: Makefile.inc1: Build source packages before sets

Summary

To build set-src, we first need to build the source packages. Add a
.ORDER to ensure this happens. Otherwise, in a parallel build, sets
might be built before the src-* packages have finished building, and
set-src will be mysteriously missing.

MFC after: 3 seconds
Reported by: cperciva
Actually diagnosed by: jrtc27
One-line fix by: ivy

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Mon, Oct 13, 6:26 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMon, Oct 13, 6:26 PM

ivy requested review of this revision.Mon, Oct 13, 6:26 PM

Harbormaster completed remote builds in B67759: Diff 164106.Mon, Oct 13, 6:26 PM

cperciva accepted this revision.Mon, Oct 13, 6:27 PM

This revision is now accepted and ready to land.Mon, Oct 13, 6:27 PM

Closed by commit rGea5685ba79fc: Makefile.inc1: Build source packages before sets (authored by ivy). · Explain WhyMon, Oct 13, 6:32 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGea5685ba79fc: Makefile.inc1: Build source packages before sets.

ivy added a commit: rG3b5ec539beef: Makefile.inc1: Build source packages before sets.

cperciva added a commit: rGf01adba1e2ac: Makefile.inc1: Build source packages before sets.Tue, Oct 14, 2:49 AM

Revision Contents
Changeset List

Path

Size

Makefile.inc1

1 line

Diff 164108

View Options

Makefile.inc1: Build source packages before setsClosedPublicActions