freebsd-update: Library ordering

[cperciva]

Summary

Upgrading from 14.x to 15.x with freebsd-update broke because libc
depends on the new libsys library; freebsd-update installed the new
libc before creating libsys, and every step after that failed because
all the tools (including gunzip and install) are dynamically linked
and need a working libc.

Enforce ordering when installing shared objects: First libsys, then
libc, then libthr, and then all the rest of the shared object files.

This is a candidate for an Errata Notice since is breaks upgrades.

MFC after: 3 days
Sponsored by: https://www.patreon.com/cperciva

[cperciva]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289769

[grahamperrin]

Thanks.

Tested with:

1. the VirtualBox guest snapshot that I used for https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=289769#c0, the standard set of base components, on UFS

2. a fresh installation of 14.3-RELEASE, the full set, on ZFS.

Both completed without error.

[kib]

usr.sbin/freebsd-update/freebsd-update.sh

3118

3123

3128

3135

[cperciva]

Fix globs per kib.

[cperciva]

@kib Thanks, fixed!

[kib]

BTW, did you ever run shell-check over freebsd-update?

[cperciva]

In D52688#1203807, @kib wrote:

BTW, did you ever run shell-check over freebsd-update?

Not until now. I don't think shellcheck even existed when I first wrote freebsd-update.

On first glance, lots of complaints about not quoting things but I don't see anything which actually matters.