release: exclude FreeBSD-lldb package for RISCV*

[dch]

From Colin via IRC, "can we exclude FreeBSD-lldb on riscv64`.
I will look into using package sets this week while at eurobsdcon, that may be a better solution.

release/tools/oci-image-toolchain.conf

20

It's not clear to me whether TARGET_ARCH is appropriate, nor whether its exclusively riscv64 or not.

[dch]

failed to build from sources here:

$ make TARGET_ARCH=riscv64 TARGET=riscv buildworld
...
Building /usr/obj/usr/src/riscv.riscv64/tools/build/test-includes/sys_abi_compat.o
error: unable to create target: 'No available targets are compatible with triple "riscv64-unknown-freebsd15.0"'
1 error generated.
*** Error code 1

I assume this is unrelated to the diff.

[cperciva]

release/tools/oci-image-toolchain.conf

24

I would spell this more like we do in src, e.g.

case "${TARGET_ARCH}" in
    riscv*) ;;
    *) _lldb="FreeBSD-lldb"
esac

packages="FreeBSD-clang ... FreeBSD-*-dev ${_lldb}"

Also maybe better to make lldb amd64/aarch64-only rather than excluded from riscv64. It's the same thing right now but if new architectures gain OCI images they're more likely to land on the "don't support lldb yet" side of things so I think an allowlist works better than a blocklist here.

[ivy]

In D52674#1203068, @dch wrote:

I will look into using package sets this week while at eurobsdcon, that may be a better solution.

as you're installing FreeBSD-*-dev, you almost certainly want to just replace all of this with FreeBSD-set-devel which avoids the problem entirely.

release/tools/oci-image-toolchain.conf

24

if you go that route it also needs to be enabled on powerpc/powerpc64 and powerpc/powerpc64le.

[emaste]

In addition to riscv, LLDB is currently also not built for (32-bit) arm; D52668 is open to address that.

[emaste]

I will look into using package sets this week while at eurobsdcon, that may be a better solution.

In case that doesn't get done, the current approach looks fine to me.

release/tools/oci-image-toolchain.conf

21

[dch]

abandoned in favour of Lexi's awesome pkg sets! https://reviews.freebsd.org/D52716