release: Add variables for makefs and mkimg arguments

[markj]

Summary

This will be useful for enabling reproducible image creation. Right
now, makefs and mkimg are generating non-reproducible images since they
preserve timestamps from files in the staging tree. To make image
creation reproducible, we need to specify an explicit timestamp using
command-line arguments. So, add variables which can be defined in
release/scripts/vmimage.subr.

No functional change intended.

[jrtc27]

Are we sure all these scripts aren't set -u? Even if that's true, I don't love relying on that.

[markj]

In D52387#1196215, @jrtc27 wrote:

Are we sure all these scripts aren't set -u? Even if that's true, I don't love relying on that.

Yes, they are definitely not set -u-clean. I don't quite follow though: how does this patch rely on that? : ${FOO:=bar} is ok even with set -u configured.

[jrtc27]

In D52387#1196252, @markj wrote:

In D52387#1196215, @jrtc27 wrote:

Are we sure all these scripts aren't set -u? Even if that's true, I don't love relying on that.

Yes, they are definitely not set -u-clean. I don't quite follow though: how does this patch rely on that? : ${FOO:=bar} is ok even with set -u configured.

The setting of the default values for ..ARGS looks to be stacked on top of this, so in this patch they are not yet defined unless the external environment sets them?

[markj]

In D52387#1196256, @jrtc27 wrote:

In D52387#1196252, @markj wrote:

In D52387#1196215, @jrtc27 wrote:

Are we sure all these scripts aren't set -u? Even if that's true, I don't love relying on that.

Yes, they are definitely not set -u-clean. I don't quite follow though: how does this patch rely on that? : ${FOO:=bar} is ok even with set -u configured.

The setting of the default values for ..ARGS looks to be stacked on top of this, so in this patch they are not yet defined unless the external environment sets them?

Oh, yes, that's true, but after the subsequent patch to set default values they should be defined everywhere. At that point, set -u would be useful (but having tried setting it locally, that will take some work).

[bnovkov]

release/amd64/make-memstick.sh

55

The MAKEFSARGS (flags) vs MAKEFSARG (target manifest) naming scheme is a bit confusing, somebody might get burned by this in the future.
Would something like MAKEFSMTREE be a better fit?

release/amd64/mkisoimages.sh

85

Minor nit, just so we remain consistent with wrapping vars in curly braces here (and in other places in this patch).

[markj]

Rename the pre-existing MAKEFSARG variable, which contains a path to a staging tree or
mtree metalog, to MAKEFSTARGET, to avoid clashing with MAKEFSARGS.

[markj]

release/amd64/make-memstick.sh

55

The argument may be a directory instead of an mtree file, so that name isn't really right. I went with MAKEFSTARGET locally, but I don't love that either. Further suggestions are welcome.