misc/fortune-mod-mormon: New port

[ziaee]

Summary

This port provides the scriptures of the Church of Jesus Christ of
Latter Day Saints broken down into 15 fortune(6) modules. It conflicts
with fortune-mod-bible, which provides a slightly different KJV Bible,
and fortune-mod-psalms, which provides the Psalms from the Douai Bible.
Note that these other fortune modules have logic to select a strfile
implementation from the days when there were multiple;
this is no longer the case.

Thanks: cperciva, kevans
Differential Revision:  https://reviews.freebsd.org/D52350

[ziaee]

improve pkg message with index

[ziaee]

this port provides the psalms and bible modules,
so add them to conflicts and improve pkg-descr somewhat.

[ziaee]

updated for portlint -A

[cperciva]

I would be inclined to have a MODS variable in Makefile and then use .for loops. Relying on shell globbing can be fragile; this would also fix for i in ${WRKSRC}/mods/*; do strfile "$$i" "$${i}.dat"; done which should not be a single line.

The strfile command doesn't need the second argument; foo -> foo.dat is the default for strfile.

[cperciva]

Oh, also if you use a MODS variable you can construct the pkg-plist in the Makefile and not need it as a separate file.

[kevans]

Also: needs an entry in misc/Makefile to hook it up, please include here as well

[ziaee]

Attempt to fix everything except constructing the plist in the Makefile.
The Porters Handbook does say it's better to have a pkg-plist so people
can use grep on it.

However, that's an excuse because I couldn't figure it out. I tried:
PLIST_FILES= $MODS:S,^,share/games/fortune/,}.dat (plus the same w/o
appending .dat) based off what I read in archivers/stuffit/Makefile,
but then pkg inf -l only shows the last .dat file?

[kevans]

In D52350#1195799, @ziaee wrote:

Attempt to fix everything except constructing the plist in the Makefile.
The Porters Handbook does say it's better to have a pkg-plist so people
can use grep on it.

However, that's an excuse because I couldn't figure it out. I tried:
PLIST_FILES= $MODS:S,^,share/games/fortune/,}.dat (plus the same w/o
appending .dat) based off what I read in archivers/stuffit/Makefile,
but then pkg inf -l only shows the last .dat file?

You would have wanted something more like ${MODS:S,^,share/,:S,$,.dat,} to append .dat to every word, so it would have had all but one invalid entry since only one gets suffixed properly. make -V PLIST_FILES is perhaps a better way to understand than having to go through packaging it.

For a port like this, I don't think maintaining the list (edit: twice) is going to be a huge maintenance burden, necessarily- I wouldn't see it as adding or removing new files very often at all.

[ziaee]

Wow, make -V is amazing! Thank you so much! This port hasn't changed
since 2006, and the material is old enough to be in the public domain.
I can't imagine anything changing, even though the README has todos.

[kevans]

I would, however, hassle you a little bit over a commit message nit. One might look and notice that fortune-mod-bible has a dance to try and be compatible with different locations of strfile, but a little bit of archaeology reveals that @cperciva killed off the need for that back in 2015 (rG11d9aa670723f508821f2bf6980a555360783a80), so there's no remaining version of FreeBSD that will not have strfile in a stock configuration (and we don't really account for special pkgbase configurations today in ports, and maybe we won't tomorrow, either). I would proactively note in the commit message that the strfile dance found in other fortune data ports isn't necessary today to preempt concerns there.

misc/fortune-mod-mormon/Makefile

25

I wouldn't think this is strictly necessary, strfile(8) explicitly truncates the output and I don't see that changing any time soon. However, I don't think I'd hassle you over this.

[arrowd]

This port should be hooked into misc/Makefile. Other than that, LGTM.