tcpdump: don't create unused version.c
ClosedPublic
Actions

Authored by brooks on Sep 2 2025, 8:50 AM.

Details

Reviewers

jrm
emaste

Commits

rG4b8eebe9754a: tcpdump: don't create unused version.c

Summary

The version now comes from the PACKAGE_VERSION macro.

Fixes: 0a7e5f1f02aa ("tcpdump: Update to 4.99.5")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks created this revision.Sep 2 2025, 8:50 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 2 2025, 8:50 AM

brooks requested review of this revision.Sep 2 2025, 8:50 AM

Harbormaster completed remote builds in B66752: Diff 161361.Sep 2 2025, 8:50 AM

brooks added a parent revision: D52333: tcpdump: drop no-op LBL_ALIGN macro.Sep 2 2025, 8:50 AM

What am I missing?

jrm@asn /usr/src/usr.sbin/tcpdump [arcpatch-D52334_1|✔] % sudo make clean
===> libnetdissect (clean)
cd: /usr/src/usr.sbin/tcpdump/libnetdissect: No such file or directory
*** Error code 2

Stop.
make: stopped making "clean" in /usr/src/usr.sbin/tcpdump

Remove stray downstream bits

Harbormaster completed remote builds in B66758: Diff 161371.Sep 2 2025, 1:20 PM

In D52334#1194932, @jrm wrote:

What am I missing?

jrm@asn /usr/src/usr.sbin/tcpdump [arcpatch-D52334_1|✔] % sudo make clean
===> libnetdissect (clean)
cd: /usr/src/usr.sbin/tcpdump/libnetdissect: No such file or directory
*** Error code 2

Stop.
make: stopped making "clean" in /usr/src/usr.sbin/tcpdump

Oops, sorry about that. I found this series of nits when doing some refactoring downstream and some of that slipped through into this diff.

jrm accepted this revision.Sep 2 2025, 1:28 PM

This revision is now accepted and ready to land.Sep 2 2025, 1:28 PM

emaste accepted this revision.Sep 2 2025, 1:34 PM

Closed by commit rG4b8eebe9754a: tcpdump: don't create unused version.c (authored by brooks). · Explain WhySep 3 2025, 12:13 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rG4b8eebe9754a: tcpdump: don't create unused version.c.