Page MenuHomeFreeBSD

vmm/hyperv: code cleanup of utility drivers
ClosedPublic

Authored by howard0su_gmail.com on Feb 6 2016, 7:16 AM.
Tags
None
Referenced Files
F106102050: D5216.diff
Wed, Dec 25, 10:39 AM
Unknown Object (File)
Tue, Dec 17, 3:20 PM
Unknown Object (File)
Sun, Dec 8, 9:31 PM
Unknown Object (File)
Tue, Dec 3, 3:58 PM
Unknown Object (File)
Nov 23 2024, 1:51 PM
Unknown Object (File)
Nov 18 2024, 7:48 AM
Unknown Object (File)
Oct 29 2024, 9:40 PM
Unknown Object (File)
Oct 15 2024, 1:21 AM

Details

Summary
  1. give right driver name for devices, instead of hvutilx
  2. move global data into driver softc structure

kvp code cleanup will submit as a separate code review.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2411
Build 2427: arc lint + arc unit

Event Timeline

howard0su_gmail.com retitled this revision from to WIP: vmm/hyperv: code cleanup of utility drivers.
howard0su_gmail.com updated this object.
howard0su_gmail.com edited the test plan for this revision. (Show Details)

Update hv_kvp driver using new hv_util functions

Fix hv_kvp and also cleanup a bit.

Cleanup KVP driver to remove all global variables.

Since there are some new added files, shall we modify the copyright to "2016"? I remember Sephie said there are some regulations on copyright.

sys/dev/hyperv/utilities/hv_heartbeat.c
3

Shall we update it to be "2016 Microsoft Corp."?

Since there are some new added files, shall we modify the copyright to "2016"? I remember Sephie said there are some regulations on copyright.

I have not checked the file content yet. However, if majority of the content of the new file is copied from other file, we need to retain the source files copyright.

Since there are some new added files, shall we modify the copyright to "2016"? I remember Sephie said there are some regulations on copyright.

I have not checked the file content yet. However, if majority of the content of the new file is copied from other file, we need to retain the source files copyright.

Most newly added files contains code is copied from original files. I don't think we should change the copyright.

howard0su_gmail.com retitled this revision from WIP: vmm/hyperv: code cleanup of utility drivers to vmm/hyperv: code cleanup of utility drivers.Feb 17 2016, 12:03 PM
howard0su_gmail.com edited edge metadata.
adrian edited edge metadata.
adrian added inline comments.
sys/dev/hyperv/utilities/hv_heartbeat.c
3

I'd update it to be 2014, 2016 Microsoft Corp.

This revision is now accepted and ready to land.Feb 18 2016, 6:21 PM
This revision was automatically updated to reflect the committed changes.