Differential D51991

icmp: clear offset and flags when reflecting a packet
ClosedPublic
Actions

Authored by tuexen on Aug 18 2025, 6:56 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Mar 9, 10:22 PM

	Unknown Object (File)
	Sat, Mar 7, 5:26 PM

	Unknown Object (File)
	Wed, Mar 4, 3:30 PM

	Unknown Object (File)
	Mon, Feb 23, 11:52 AM

	Unknown Object (File)
	Sun, Feb 22, 9:37 PM

	Unknown Object (File)
	Jan 25 2026, 4:20 AM

	Unknown Object (File)
	Jan 25 2026, 3:26 AM

	Unknown Object (File)
	Jan 21 2026, 3:33 PM

View All 44 Files

Subscribers

imp

melifaro

Details

Reviewers

markj
glebius
zlei
ae

Commits

rG9feb2ac05b77: icmp: clear offset and flags when reflecting a packet
rGb9a2d84b1bf7: icmp: clear offset and flags when reflecting a packet

Summary

When reflecting a packet, use an offset of 0 and clear all three bits, in particular to DF bit.

This fixes PR 288558.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Aug 18 2025, 6:56 AM

Herald added subscribers: melifaro, imp. · View Herald TranscriptAug 18 2025, 6:56 AM

tuexen requested review of this revision.Aug 18 2025, 6:56 AM

markj accepted this revision.Aug 18 2025, 1:01 PM

This revision is now accepted and ready to land.Aug 18 2025, 1:01 PM

Looks good to me.

Closed by commit rGb9a2d84b1bf7: icmp: clear offset and flags when reflecting a packet (authored by tuexen). · Explain WhyAug 18 2025, 5:19 PM

This revision was automatically updated to reflect the committed changes.

tuexen added a commit: rGb9a2d84b1bf7: icmp: clear offset and flags when reflecting a packet.

tuexen added a commit: rG9feb2ac05b77: icmp: clear offset and flags when reflecting a packet.Sep 5 2025, 7:06 PM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_icmp.c

3 lines

Diff 160558

View Options

icmp: clear offset and flags when reflecting a packetClosedPublicActions