Page MenuHomeFreeBSD
Differential D51926

Makefile.libcompat: Add krb5/util
ClosedPublic
Actions

Authored by ivy on Aug 15 2025, 8:31 PM.
Tags
None
Referenced Files
F132586197: D51926.id160414.diff
Sat, Oct 18, 4:53 AM
Unknown Object (File)
Wed, Oct 15, 3:36 AM
Unknown Object (File)
Sun, Oct 12, 8:53 PM
Unknown Object (File)
Sat, Oct 11, 8:12 PM
Unknown Object (File)
Sat, Oct 11, 8:12 PM
Unknown Object (File)
Sat, Oct 11, 11:15 AM
Unknown Object (File)
Sat, Oct 11, 11:15 AM
Unknown Object (File)
Sat, Oct 11, 11:15 AM
View All 28 Files
Subscribers
des
eadler
imp
ngie

Details

Reviewers
ngie
des
Group Reviewers
krb5
Commits
rGfb13ae28b2e8: Makefile.libcompat: Add krb5/util
Summary

This fixes missing libraries (libcom_err, libkrb5profile, ...)
for the 32-bit build, since these libraries live in krb5/util.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy created this revision.Aug 15 2025, 8:31 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 15 2025, 8:31 PM
ivy requested review of this revision.Aug 15 2025, 8:31 PM
Harbormaster completed remote builds in B66276: Diff 160412.Aug 15 2025, 8:31 PM
ivy updated this revision to Diff 160414.Aug 15 2025, 8:39 PM

be a little more idiomatic

Harbormaster completed remote builds in B66277: Diff 160414.Aug 15 2025, 8:39 PM
ngie accepted this revision.Aug 16 2025, 4:15 AM
ngie added a subscriber: ngie.

Macro shipit:

This revision is now accepted and ready to land.Aug 16 2025, 4:15 AM
des accepted this revision.EditedAug 16 2025, 10:32 AM
des added a subscriber: des.

why are you posting a photo of the grave of 32 people in a code review?

ngie added a comment.Aug 16 2025, 6:30 PM
In D51926#1186791, @des wrote:

why are you posting a photo of the grave of 32 people in a code review?

I just used the "shipit" macro not knowing the historical context. I've edited the macro to use a picture of a cute cat in a captain hat instead.

Macro shipit:

Closed by commit rGfb13ae28b2e8: Makefile.libcompat: Add krb5/util (authored by ivy). · Explain WhyAug 16 2025, 8:08 PM
This revision was automatically updated to reflect the committed changes.
ivy added a commit: rGfb13ae28b2e8: Makefile.libcompat: Add krb5/util.
ngie added a subscriber: eadler.Aug 16 2025, 9:10 PM
In D51926#1186856, @ngie wrote:
In D51926#1186791, @des wrote:

why are you posting a photo of the grave of 32 people in a code review?

I just used the "shipit" macro not knowing the historical context. I've edited the macro to use a picture of a cute cat in a captain hat instead.

Macro shipit:

PS Please feel free to comment on the macros in the comment box or edit the macros next time (@eadler hasn't been on Phabricator in 3 years, so I figured direct editing the macro was ok).

Revision Contents
Changeset List

PathSize
1 line

Diff 160435

View Options

Makefile.libcompat

Loading...