Page MenuHomeFreeBSD

tests/ci: rely on pre-existing *_CONF make variables
AbandonedPublic

Authored by guest-svmhdvn on Jul 28 2025, 8:04 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 20, 4:56 AM
Unknown Object (File)
Sat, Oct 11, 7:06 AM
Unknown Object (File)
Sat, Oct 11, 7:06 AM
Unknown Object (File)
Fri, Oct 10, 11:48 PM
Unknown Object (File)
Sun, Oct 5, 6:07 AM
Unknown Object (File)
Sep 19 2025, 11:30 AM
Unknown Object (File)
Sep 17 2025, 4:47 AM
Unknown Object (File)
Sep 15 2025, 8:09 PM
Subscribers

Details

Reviewers
lwhsu
bofh
Summary

This patch removes the unnecessary MAKECONF and SRCCONF
from tests/ci/Makefile and relies on the following
pre-existing standard variables to control its configuration:

__MAKE_CONF for make.conf
SRCCONF for src.conf
SRC_ENV_CONF for src-env.conf

This also removes the WITH_META_MODE custom logic, since that
can easily be controlled through SRC_ENV_CONF already.

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I don't think that this is correct at this moment. The reasons are:

  1. This patch(MAKECONF/SRCCONF) will be helpful when we fully control the different ci tasks from the root Makefile which is up for future discussion
  2. The primary reason we add these logics(METAMODE) are so that a developer has to do less when they are running their pre-commit CI checklist at their terminal or choice of environment

The primary task for us is to make running ci easier for end developers not our CI tasks. But I believe @imp can shade some more light onto the concept.

I understand that you are trying to make some improvements here but before that you should actually read/understand/realize why we started this project or what was the rationale behind this. Ask @jrm for a copy of the original proposal from 2022. Time has changed and there are new variables in the play but the goal should be same.

Abandoning due to feedback.