Page MenuHomeFreeBSD

tests/ci: fix missing /usr/local/{sbin,bin} in freebsdci rc PATH
ClosedPublic

Authored by guest-svmhdvn on Jul 14 2025, 3:03 PM.
Tags
None
Referenced Files
F132397142: D51303.diff
Thu, Oct 16, 2:03 PM
Unknown Object (File)
Sat, Oct 11, 7:07 AM
Unknown Object (File)
Sat, Oct 11, 7:07 AM
Unknown Object (File)
Sat, Oct 11, 7:07 AM
Unknown Object (File)
Fri, Oct 10, 11:48 PM
Unknown Object (File)
Sun, Oct 5, 6:16 AM
Unknown Object (File)
Wed, Sep 17, 10:49 AM
Unknown Object (File)
Sep 15 2025, 11:14 PM
Subscribers

Details

Summary

Currently, a lot of tests report 'skipped' due to missing binaries
in the PATH. The real issue is that /etc/rc forcibly restricts the
PATH to the base system only.

This patch re-enables a large chunk of skipped tests by adding
the missing LOCALBASE directories to the PATH so that Kyua can
discover third-party packages. It also fixes some minor rc scripting
style as per the official freebsd scripting guide[0].

[0] https://docs.freebsd.org/en/articles/rc-scripting

Signed-off-by: Siva Mahadevan <me@svmhdvn.name>
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

guest-svmhdvn added reviewers: ngie, bofh, lwhsu, imp.

I've added a stack of diffs here. Let me know if I need to add all reviewers to each review in the stack. I didn't want to spam everyone, so I've left it like this.

I think this one(tests/ci: fix missing /usr/local/{sbin,bin} in freebsdci rc PATH) can land without further actions/discussions. Although I will need to check others.

This revision is now accepted and ready to land.Jul 16 2025, 7:19 PM