Page MenuHomeFreeBSD

bsdinstall: use the canonical name for compression
ClosedPublic

Authored by ivy on Jul 27 2025, 1:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 6:24 AM
Unknown Object (File)
Sun, Oct 12, 6:23 AM
Unknown Object (File)
Sun, Oct 12, 6:23 AM
Unknown Object (File)
Sun, Oct 12, 6:23 AM
Unknown Object (File)
Sat, Oct 11, 8:11 PM
Unknown Object (File)
Thu, Oct 2, 1:38 AM
Unknown Object (File)
Wed, Oct 1, 10:11 PM
Unknown Object (File)
Wed, Oct 1, 4:46 AM

Details

Summary

According to zfsprops(7), the canonical property for the compression
algorithm is "compression", with "compress" accepted as an alternate
name. Use the canonical name in bsdinstall.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy requested review of this revision.Jul 27 2025, 1:29 PM
delphij added a subscriber: delphij.

I think it makes sense to just leave compression to on (use the default, which is lz4 for the current ZFS version) instead of explicitly saying lz4 here because that would be more future proof. The change looks otherwise fine to me.

This revision is now accepted and ready to land.Jul 27 2025, 6:57 PM

use 'on' instead of 'lz4'

This revision now requires review to proceed.Jul 27 2025, 7:12 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 28 2025, 12:46 PM
This revision was automatically updated to reflect the committed changes.