Page MenuHomeFreeBSD

chroot: don't clobber the egid with the first supplemental group
ClosedPublic

Authored by kevans on Jul 25 2025, 5:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 5:56 PM
Unknown Object (File)
Wed, Oct 15, 7:21 PM
Unknown Object (File)
Sat, Oct 11, 12:34 AM
Unknown Object (File)
Fri, Oct 10, 5:52 AM
Unknown Object (File)
Fri, Oct 10, 5:52 AM
Unknown Object (File)
Fri, Oct 10, 5:52 AM
Unknown Object (File)
Fri, Oct 10, 12:16 AM
Unknown Object (File)
Wed, Oct 8, 2:36 PM
Subscribers

Details

Summary

There are two problems here, really:

1.) If -G is specified, the egid of the runner will get clobbered by

the first supplemental group

2.) If both -G and -g are specified, the first supplemental group will

get clobbered by the -g group

Ideally our users shouldn't have to understand the quirks of our
setgroups(2) and the manpage doesn't describe the group list as needing
to contain the egid, so populate the egid slot as necessary.

I note that this code seems to have already been marginally aware of the
historical behavior because it was allocating NGROUPS_MAX + 1, but this
is an artifact of a later conversion to doing dynamic allocations
instead of pushing NGROUPS_MAX arrays on the stack -- the original code
did in-fact only have an NGROUPS_MAX-sized array, and the layout was
still incorrect.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable