HomeFreeBSD

chroot: don't clobber the egid with the first supplemental group

Description

chroot: don't clobber the egid with the first supplemental group

There are two problems here, really:

1.) If -G is specified, the egid of the runner will get clobbered by

the first supplemental group

2.) If both -G and -g are specified, the first supplemental group will

get clobbered by the -g group

Ideally our users shouldn't have to understand the quirks of our
setgroups(2) and the manpage doesn't describe the group list as needing
to contain the egid, so populate the egid slot as necessary.

I note that this code seems to have already been marginally aware of the
historical behavior because it was allocating NGROUPS_MAX + 1, but this
is an artifact of a later conversion to doing dynamic allocations
instead of pushing NGROUPS_MAX arrays on the stack -- the original code
did in-fact only have an NGROUPS_MAX-sized array, and the layout was
still incorrect.

MFC after: 3 days
Reviewed by: olce
Differential Revision: https://reviews.freebsd.org/D51508

Details

Provenance
kevansAuthored on Jul 26 2025, 6:11 AM
Reviewer
olce
Differential Revision
D51508: chroot: don't clobber the egid with the first supplemental group
Parents
rG1f2c178e5688: find: Use formats that work on 32-bit too...
Branches
Unknown
Tags
Unknown