Page MenuHomeFreeBSD

vfs: Assert that VOP_READDIR sets *eofflag properly
ClosedPublic

Authored by markj on Jul 14 2025, 2:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 29, 4:09 AM
Unknown Object (File)
Oct 12 2025, 9:06 AM
Unknown Object (File)
Oct 12 2025, 9:06 AM
Unknown Object (File)
Oct 11 2025, 10:19 PM
Unknown Object (File)
Oct 11 2025, 1:06 PM
Unknown Object (File)
Oct 11 2025, 4:54 AM
Unknown Object (File)
Oct 10 2025, 5:55 PM
Unknown Object (File)
Sep 30 2025, 8:54 PM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 65432
Build 62315: arc lint + arc unit

Event Timeline

markj requested review of this revision.Jul 14 2025, 2:05 PM

Only cosmetic nits.

sys/kern/vnode_if.src
384

Other _pre and _post macros use lower case

sys/sys/vnode.h
1019

This is pure cosmetic, but we usually add the opening '{' (or do {)in the upper half of the split macro, and closing '}' (} while (0)) in the lower half. See e.g. DROP_GIANT/PICKUP_GIANT.

1024

I would move nresid declaration in the same place as oresid.

1040
sys/kern/vnode_if.src
384

I was copying VOP_WRITE in that respect. Should it change too?

sys/kern/vnode_if.src
384

I would like this to be done, in separate commit.

markj marked 4 inline comments as done.

Handle kib's comments.

This revision is now accepted and ready to land.Jul 14 2025, 11:20 PM