Suggested by: kib
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 65432 Build 62315: arc lint + arc unit
Event Timeline
Comment Actions
Only cosmetic nits.
| sys/kern/vnode_if.src | ||
|---|---|---|
| 384 | Other _pre and _post macros use lower case | |
| sys/sys/vnode.h | ||
| 1019 | This is pure cosmetic, but we usually add the opening '{' (or do {)in the upper half of the split macro, and closing '}' (} while (0)) in the lower half. See e.g. DROP_GIANT/PICKUP_GIANT. | |
| 1024 | I would move nresid declaration in the same place as oresid. | |
| 1040 | ||
| sys/kern/vnode_if.src | ||
|---|---|---|
| 384 | I was copying VOP_WRITE in that respect. Should it change too? | |
| sys/kern/vnode_if.src | ||
|---|---|---|
| 384 | I would like this to be done, in separate commit. | |