Page MenuHomeFreeBSD

vfs: Assert that VOP_READDIR sets *eofflag properly
ClosedPublic

Authored by markj on Jul 14 2025, 2:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 21, 8:30 AM
Unknown Object (File)
Tue, Apr 21, 8:23 AM
Unknown Object (File)
Sun, Apr 12, 4:22 PM
Unknown Object (File)
Sun, Apr 12, 4:14 PM
Unknown Object (File)
Fri, Apr 3, 11:50 AM
Unknown Object (File)
Thu, Apr 2, 8:31 PM
Unknown Object (File)
Tue, Mar 31, 7:21 PM
Unknown Object (File)
Sat, Mar 28, 3:38 PM
Subscribers

Details

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Jul 14 2025, 2:05 PM

Only cosmetic nits.

sys/kern/vnode_if.src
384

Other _pre and _post macros use lower case

sys/sys/vnode.h
1019

This is pure cosmetic, but we usually add the opening '{' (or do {)in the upper half of the split macro, and closing '}' (} while (0)) in the lower half. See e.g. DROP_GIANT/PICKUP_GIANT.

1024

I would move nresid declaration in the same place as oresid.

1040
sys/kern/vnode_if.src
384

I was copying VOP_WRITE in that respect. Should it change too?

sys/kern/vnode_if.src
384

I would like this to be done, in separate commit.

markj marked 4 inline comments as done.

Handle kib's comments.

This revision is now accepted and ready to land.Jul 14 2025, 11:20 PM