Page MenuHomeFreeBSD
Differential D5092

Convert ss_sp in stack_t and sigstack to void *.
ClosedPublic
Actions

Authored by jhb on Jan 27 2016, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 16, 4:03 PM
Unknown Object (File)
Mon, Oct 14, 10:32 PM
Unknown Object (File)
Mon, Oct 14, 10:32 PM
Unknown Object (File)
Mon, Oct 14, 4:08 AM
Unknown Object (File)
Sat, Oct 12, 3:51 PM
Unknown Object (File)
Fri, Oct 11, 7:43 AM
Unknown Object (File)
Wed, Oct 9, 5:50 PM
Unknown Object (File)
Wed, Oct 9, 3:01 PM
View All 79 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
kib
jhibbits
Commits
rS294930: Convert ss_sp in stack_t and sigstack to void *.
Summary

Convert ss_sp in stack_t and sigstack to void *.

POSIX requires these members to be of type void * rather than the
char * inherited from 4BSD. NetBSD and OpenBSD both changed their
fields to void * back in 1998. No new build failures were reported
via an exp-run.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 12760.Jan 27 2016, 3:53 PM
jhb retitled this revision from to Convert ss_sp in stack_t and sigstack to void *..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: kib.
Herald added a reviewer: jhibbits. · View Herald TranscriptJan 27 2016, 3:53 PM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
kib accepted this revision.Jan 27 2016, 4:58 PM
kib edited edge metadata.
kib added inline comments.
sys/amd64/amd64/machdep.c
392 ↗(On Diff #12760)

It would be cleaner to change the sp type to uintptr_t as well, but this is for later.

This revision is now accepted and ready to land.Jan 27 2016, 4:58 PM
Closed by commit rS294930: Convert ss_sp in stack_t and sigstack to void *. (authored by jhb). · Explain WhyJan 27 2016, 5:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
amd64/
amd64/
2 lines
ia32/
6 lines
linux/
2 lines
linux32/
4 lines
arm/
arm/
2 lines
arm64/
arm64/
2 lines
2 lines
i386/
i386/
6 lines
linux/
4 lines
svr4/
2 lines
mips/
mips/
2 lines
2 lines
2 lines
powerpc/
powerpc/
2 lines
sparc64/
sparc64/
2 lines
sys/
5 lines

Diff 12768

View Options

head/sys/amd64/amd64/machdep.c

Loading...
View Options

head/sys/amd64/ia32/ia32_signal.c

Loading...
View Options

head/sys/amd64/linux/linux_sysvec.c

Loading...
View Options

head/sys/amd64/linux32/linux32_sysvec.c

Loading...
View Options

head/sys/arm/arm/machdep.c

Loading...
View Options

head/sys/arm64/arm64/machdep.c

Loading...
View Options

head/sys/arm64/arm64/vm_machdep.c

Loading...
View Options

head/sys/i386/i386/machdep.c

Loading...
View Options

head/sys/i386/linux/linux_sysvec.c

Loading...
View Options

head/sys/i386/svr4/svr4_machdep.c

Loading...
View Options

head/sys/mips/mips/freebsd32_machdep.c

Loading...
View Options

head/sys/mips/mips/pm_machdep.c

Loading...
View Options

head/sys/mips/mips/vm_machdep.c

Loading...
View Options

head/sys/powerpc/powerpc/exec_machdep.c

Loading...
View Options

head/sys/sparc64/sparc64/machdep.c

Loading...
View Options

head/sys/sys/signal.h

Loading...