build.7: PORTS_MODULES incompatible with pkgbase
ClosedPublic
Actions

Authored by ziaee on May 14 2025, 6:26 PM.

Details

Reviewers

mhorne
carlavilla
emaste
ivy

Group Reviewers

pkgbase
manpages

Commits

rG5f35cb47c684: build.7: PORTS_MODULES incompatible with pkgbase
rG1a060e4f1ba9: build.7: PORTS_MODULES incompatible with pkgbase

Summary

Add a note until we can fix this.

Discussed with: emaste

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ziaee created this revision.May 14 2025, 6:26 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2025, 6:26 PM

ziaee requested review of this revision.May 14 2025, 6:26 PM

Harbormaster completed remote builds in B64183: Diff 155463.May 14 2025, 6:26 PM

ziaee mentioned this in D50289: build.7: Improve building pkgbase.May 14 2025, 7:38 PM

ivy accepted this revision.May 14 2025, 7:55 PM

This revision is now accepted and ready to land.May 14 2025, 7:55 PM

OK.

I think it reads a bit strangely, probably because of our use of packages as the make target which fits too easily into prose. If the target was pkgbase, for example, then in "incompatible with pkgbase" it would clearly not be just an ordinary English word. It should be fine thanks to the Cm markup though.

We ought to have a PR for the incompatibility.

carlavilla accepted this revision.May 21 2025, 6:24 AM

Closed by commit rG1a060e4f1ba9: build.7: PORTS_MODULES incompatible with pkgbase (authored by ziaee). · Explain WhyMay 21 2025, 4:43 PM

This revision was automatically updated to reflect the committed changes.

ziaee added a commit: rG1a060e4f1ba9: build.7: PORTS_MODULES incompatible with pkgbase.

ziaee added a commit: rG5f35cb47c684: build.7: PORTS_MODULES incompatible with pkgbase.Jul 4 2025, 6:23 PM