Page MenuHomeFreeBSD
Differential D50316

vfs: Sort includes in vfs_vnops.c
ClosedPublic
Actions

Authored by markj on May 12 2025, 8:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 11, 7:30 AM
Unknown Object (File)
Wed, Jun 11, 12:45 AM
Unknown Object (File)
Tue, Jun 10, 7:35 PM
Unknown Object (File)
Sun, Jun 8, 4:24 PM
Unknown Object (File)
Sat, Jun 7, 8:51 AM
Unknown Object (File)
Tue, May 27, 2:25 AM
Unknown Object (File)
Sun, May 25, 11:34 PM
Unknown Object (File)
Wed, May 14, 5:54 PM
View All 10 Files
Subscribers
imp

Details

Reviewers
kib
olce
Commits
rGaee6c83e06a8: vfs: Sort includes in vfs_vnops.c
Summary

Remove some that are not needed. No functional change intended.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.May 12 2025, 8:54 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 12 2025, 8:54 PM
markj requested review of this revision.May 12 2025, 8:54 PM
Harbormaster completed remote builds in B64111: Diff 155355.May 12 2025, 8:54 PM
markj added a child revision: D50317: vfs: Sort includes in vfs_syscalls.c.May 12 2025, 8:54 PM
olce accepted this revision.May 12 2025, 9:29 PM
This revision is now accepted and ready to land.May 12 2025, 9:29 PM
kib added inline comments.May 13 2025, 12:58 AM
sys/kern/vfs_vnops.c
45

sys/systm.h already includes sys/param.h

47

I cannot find uses of 'struct bio' or BIO_XXX symbols. Might be, this header is not needed?

49

Do we need sys/conf.h there at all? I did not checked, but suspect that it is not needed, at least directly.

markj updated this revision to Diff 155397.Tue, May 13, 2:52 PM
markj marked 3 inline comments as done.

Remove some more unneeded includes.

This revision now requires review to proceed.Tue, May 13, 2:52 PM
Harbormaster completed remote builds in B64140: Diff 155397.Tue, May 13, 2:52 PM
olce accepted this revision.Tue, May 13, 3:35 PM
olce added inline comments.
sys/kern/vfs_vnops.c
45

sys/systm.h already includes sys/param.h

There is no mention in style(9) that sys/param.h must not be directly included even if sys/systm.h is also. On the contrary, it evokes their ordering when both should be included.

As said elsewhere, we should stick with listing all the includes that are directly needed, unless we have clear agreed-upon exceptions (which are equivalent to a kind of commitment that the headers won't be disentangled).

If you wish that sys/param.h is not listed when sys/systm.h is included, then please propose a draft modifying style(9). Actually, sys/systm.h includes sys/param.h only on _KERNEL, not in userland. This would need to be spelled clearly in such a proposal (and seems a drawback to me). In the meantime, I would not remove sys/param.h here.

This revision is now accepted and ready to land.Tue, May 13, 3:35 PM
olce mentioned this in D50317: vfs: Sort includes in vfs_syscalls.c.Tue, May 13, 3:36 PM
kib accepted this revision.Tue, May 13, 4:24 PM
kib added inline comments.
sys/kern/vfs_vnops.c
45

sys/systm.h was written as a convenience header providing the set of the kernel symbols. sys/param.h is part of the systm.h contract.

Closed by commit rGaee6c83e06a8: vfs: Sort includes in vfs_vnops.c (authored by markj). · Explain WhyTue, May 13, 11:33 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGaee6c83e06a8: vfs: Sort includes in vfs_vnops.c.

Revision Contents
Changeset List

PathSize
sys/
kern/
25 lines

Diff 155420

View Options

sys/kern/vfs_vnops.c

Loading...