Page MenuHomeFreeBSD

vn_delayed_setsize(): post-commit review' changes
AcceptedPublic

Authored by kib on Fri, Mar 6, 12:23 AM.

Details

Reviewers
markj
rmacklem
Summary

Rename the flag from VI_DELAYEDSSZ to VI_DELAYED_SETSIZE.
Change signature of vn_lock_delayed_setsize() to take flatten values
list instead of vop args structure.
__predict_true() for VI_DELAYED_SETSIZE not set.
Minor editings like removing tautological assert, and sorting items.

Fixes: 45117ffcd533ddf995f654db60b10899ae8370ec

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib requested review of this revision.Fri, Mar 6, 12:23 AM
rmacklem added inline comments.
sys/fs/deadfs/dead_vnops.c
58

If you are keeping the in alphabetical
order, maybe you could move the last
two entries as well?
(This is up to you.)

This revision is now accepted and ready to land.Fri, Mar 6, 1:09 AM
kib marked an inline comment as done.

More ordering for deadfs vops.

This revision now requires review to proceed.Fri, Mar 6, 1:17 AM
This revision is now accepted and ready to land.Fri, Mar 6, 1:18 AM