sys/queue.h: use reserved identifiers with the file scope for locals
ClosedPublic
Actions

Authored by kib on May 6 2025, 6:17 PM.

Details

Reviewers

olce
markj
emaste

Commits

rGc15cdaf50584: sys/queue.h: use reserved identifiers with the file scope for locals

Summary

This should prevent conflicts with the C-standard compliant code, although sys/queue.h is not a standard header.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.May 6 2025, 6:17 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 6 2025, 6:17 PM

kib requested review of this revision.May 6 2025, 6:17 PM

For me __curelm is a bit more readable than _Curelm, but I'm fine with this versino as well.

This revision is now accepted and ready to land.May 6 2025, 6:30 PM

In D50216#1145253, @emaste wrote:

For me __curelm is a bit more readable than _Curelm, but I'm fine with this versino as well.

7.1.3 Reserved identiﬁers
— All identiﬁers that begin with an underscore and either an uppercase letter or another under-
score are always reserved for any use, except those identiﬁers which are lexically identical to
keywords.187)
— All identiﬁers that begin with an underscore are always reserved for use as identiﬁers with ﬁle
scope in both the ordinary and tag name spaces.
...

I.e. only _[A-Z].* are allowed for use in macros.

Closed by commit rGc15cdaf50584: sys/queue.h: use reserved identifiers with the file scope for locals (authored by kib). · Explain WhyMay 6 2025, 10:21 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rGc15cdaf50584: sys/queue.h: use reserved identifiers with the file scope for locals.