Page MenuHomeFreeBSD

vm_object: use iterator in populate()
ClosedPublic

Authored by dougm on Apr 21 2025, 3:23 AM.
Tags
None
Referenced Files
F118834974: D49938.diff
Mon, Jun 2, 10:26 AM
Unknown Object (File)
Wed, May 21, 9:10 PM
Unknown Object (File)
Wed, May 21, 2:59 AM
Unknown Object (File)
Sat, May 17, 1:06 PM
Unknown Object (File)
Wed, May 14, 11:16 AM
Unknown Object (File)
Sat, May 10, 9:32 PM
Unknown Object (File)
Apr 29 2025, 6:58 PM
Unknown Object (File)
Apr 28 2025, 11:46 PM
Subscribers

Details

Summary

Use an iterator instead of tailq pointers in vm_object_populate().

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm requested review of this revision.Apr 21 2025, 3:23 AM
dougm created this revision.
sys/vm/vm_object.c
2156

I can't use VM_RADIX_FOREACH because when page[start] is NULL, the loop should end but VM_RADIX_FORALL would just start with the first page > start.

I can't use VM_RADIX_FORALL because the original code can skip gaps of null pages, and FORALL cannot.

sys/vm/vm_object.c
2156

Perhaps add this text to the commit message, if not as a comment into the code.

dougm added a reviewer: alc.

Use the same iterator for grabbing and for unbusying. Use VM_RADIX_FORALL with an upper bound.

sys/vm/vm_object.c
2155
This revision is now accepted and ready to land.Apr 24 2025, 11:37 PM
This revision was automatically updated to reflect the committed changes.