Paths

Table of Contentst

Differential D49907

etc: add config tag to /root/.k5login
ClosedPublic
Actions

Authored by ivy on Apr 19 2025, 5:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 17, 11:19 AM

	Unknown Object (File)
	Mon, Dec 15, 4:39 PM

	Unknown Object (File)
	Thu, Nov 27, 3:52 PM

	Unknown Object (File)
	Wed, Nov 26, 7:21 PM

	Unknown Object (File)
	Nov 17 2025, 1:18 AM

	Unknown Object (File)
	Nov 17 2025, 1:18 AM

	Unknown Object (File)
	Nov 14 2025, 10:28 AM

	Unknown Object (File)
	Nov 14 2025, 5:06 AM

View All 49 Files

Subscribers

Details

Reviewers

kevans
des
manu
bapt

Group Reviewers

Commits

rG77e0f080b2f8: etc: add config tag to /root/.k5login
rG2109eff09897: etc: add config tag to /root/.k5login
rGeef0c78e435d: etc: add config tag to /root/.k5login

Summary

this prevents the file being overwritten every time FreeBSD-runtime is
upgraded.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Apr 19 2025, 5:48 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 19 2025, 5:48 AM

ivy requested review of this revision.Apr 19 2025, 5:48 AM

Harbormaster completed remote builds in B63588: Diff 153908.Apr 19 2025, 5:48 AM

I went looking for other examples of the config tag and saw that none of /root/.shrc, /root/.profile, /root/.cshrc, /root/.login have it. We should probably fix that. I believe adding ROOTTAGS=config to bin/sh/Makefile and bin/csh/Makefile will do the trick.

In D49907#1137997, @des wrote:

I went looking for other examples of the config tag and saw that none of /root/.shrc, /root/.profile, /root/.cshrc, /root/.login have it.

but, they do end up with the config tag in the built system (worldstage/runtime.plist):

@config(root,wheel,0644,) /root/.profile
@config(root,wheel,0644,) /root/.shrc

/root/.k5login seems to be the only one missing. my recollection (when i originally fixed this a couple months back) is that the other files are part of things that already have the correct Makefile logic for this (like sh, csh) while k5login was missed because it's installed specially.

We should probably fix that. I believe adding ROOTTAGS=config to bin/sh/Makefile and bin/csh/Makefile will do the trick.

i am not opposed to this but, given these files already install with the correct tags, is it necessary?

In D49907#1138529, @ivy wrote:

i am not opposed to this but, given these files already install with the correct tags, is it necessary?

No, it's clearly already taken care of by some magic elsewhere that I'm not aware of.

This revision is now accepted and ready to land.Apr 21 2025, 5:26 PM

Closed by commit rGeef0c78e435d: etc: add config tag to /root/.k5login (authored by ivy). · Explain WhyApr 23 2025, 4:41 AM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rGeef0c78e435d: etc: add config tag to /root/.k5login.

ivy added a commit: rG2109eff09897: etc: add config tag to /root/.k5login.May 7 2025, 6:43 PM

ivy added a commit: rG77e0f080b2f8: etc: add config tag to /root/.k5login.May 7 2025, 6:46 PM

Revision Contents
Changeset List

Path

Size

etc/

2 lines

Diff 154138

etc/Makefile

Loading...