Page MenuHomeFreeBSD

hyperv/hn: Use m_copydata for chimney sending.
ClosedPublic

Authored by sepherosa_gmail.com on Jan 18 2016, 8:42 AM.
Tags
None
Referenced Files
F131554726: D4977.vs12412.id12669.diff
Thu, Oct 9, 5:28 AM
Unknown Object (File)
Thu, Sep 18, 4:44 PM
Unknown Object (File)
Sat, Sep 13, 6:13 PM
Unknown Object (File)
Sep 9 2025, 9:16 PM
Unknown Object (File)
Sep 3 2025, 11:59 AM
Unknown Object (File)
Sep 1 2025, 4:21 AM
Unknown Object (File)
Aug 31 2025, 11:26 AM
Unknown Object (File)
Aug 3 2025, 5:25 AM
Subscribers

Details

Summary

While I'm here, move stack variables near their usage.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to hyperv/hn: Use m_copydata for chimney sending..
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)

If no objection comes, it will be committed two days later

sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
947 โ†—(On Diff #12412)

why uint8*? the last parameter is caddr_t

m_copydata(const struct mbuf *mbuf, int offset, int len, caddr_t buf);

sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c
947 โ†—(On Diff #12412)

caddr_t is char *, I generally like to use uint8_t * for byte array, instead of char *. I don't think we have -Wpointer-sign in kernel compiling cc flags, so uint8_t * has same effect as char */caddr_t for m_copydata()

delphij edited edge metadata.

Looks good to me.

This revision is now accepted and ready to land.Jan 19 2016, 1:28 AM
adrian edited edge metadata.
This revision was automatically updated to reflect the committed changes.