vm_grab: reset iter after alloc failure
ClosedPublic
Actions

Authored by dougm on Apr 10 2025, 6:48 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 26, 11:27 PM

	Unknown Object (File)
	Sat, Nov 22, 12:31 AM

	Unknown Object (File)
	Fri, Nov 21, 4:02 AM

	Unknown Object (File)
	Oct 24 2025, 12:20 AM

	Unknown Object (File)
	Oct 22 2025, 11:46 PM

	Unknown Object (File)
	Oct 20 2025, 12:02 AM

	Unknown Object (File)
	Oct 13 2025, 2:55 AM

	Unknown Object (File)
	Sep 27 2025, 11:25 PM

View All 46 Files

Subscribers

imp

pho

Details

Reviewers

kib
alc

Commits

rG14efeab6adba: vm_grab: reset iter after alloc failure

Summary

After vm_page_grab_lookup fails to find a page, and vm_page_alloc_after fails to allocate one, reset the pages iterator which is invalidated by a release/acquire of the object write lock within the allocation code.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dougm requested review of this revision.Apr 10 2025, 6:48 AM

dougm created this revision.

kib accepted this revision.Apr 10 2025, 6:50 AM

This revision is now accepted and ready to land.Apr 10 2025, 6:50 AM

Fixes: 7becd87c988c ("vm_grab: use iterator for grab lookup")

Closed by commit rG14efeab6adba: vm_grab: reset iter after alloc failure (authored by dougm). · Explain WhyApr 10 2025, 7:10 AM

This revision was automatically updated to reflect the committed changes.

dougm added a commit: rG14efeab6adba: vm_grab: reset iter after alloc failure.

Herald added a subscriber: imp. · View Herald TranscriptApr 10 2025, 7:10 AM

Revision Contents
Changeset List

Path

Size

sys/

vm/

vm_page.c

2 lines

Diff 153438

View Options

vm_grab: reset iter after alloc failureClosedPublicActions