Page MenuHomeFreeBSD

netinet: Make ip.h self-contained
ClosedPublic

Authored by markj on Apr 9 2025, 1:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 7:23 PM
Unknown Object (File)
Sun, Oct 12, 6:54 PM
Unknown Object (File)
Wed, Oct 8, 2:37 PM
Unknown Object (File)
Wed, Oct 8, 7:42 AM
Unknown Object (File)
Tue, Oct 7, 2:35 PM
Unknown Object (File)
Thu, Oct 2, 11:55 AM
Unknown Object (File)
Sun, Sep 28, 2:42 AM
Unknown Object (File)
Sat, Sep 27, 12:23 AM
Subscribers

Details

Summary

cdefs.h is included for __packed; just assume that types.h includes
cdefs.h as that's a very common assumption.

PR: 285924

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj requested review of this revision.Apr 9 2025, 1:41 PM

IMO the commit message could use one more sentence introducing the justification (which was reasonably explained in either the PR or the upstream report IIRC) but LGTM.

This revision is now accepted and ready to land.Apr 9 2025, 1:45 PM

Also we have some commentary in style(9) about kernel headers visible to userland applications:

In header files visible to userland applications, prototypes that are
visible must use either “protected” names (ones beginning with an
underscore) or no names with the types.  It is preferable to use
protected names.  E.g., use:

We ought to make a note of our (evolving) approach wrt self-contained headers there. I can pick that up if nobody else wants to.

We ought to make a note of our (evolving) approach wrt self-contained headers there. I can pick that up if nobody else wants to.

Since you volunteered... :)

This revision was automatically updated to reflect the committed changes.