[PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl
ClosedPublic
Actions

Authored by rpokala on Jan 14 2016, 1:46 AM.

Details

Reviewers

hiren
darius-dons.net.au

Group Reviewers

Contributor Reviewers (ports)

Commits

rS294070: [PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl

Summary

r287723 removed some cleanup from lagg(4), which leads to panics when
changing configuration. Restore the spirit of the code which was removed.
This issue has been refactored out of existence in -HEAD, so this patch is
directly against stable/10.

Test Plan

Create and destroy lagg, add and remove ports, switch laggprotos; used to panic, doesn't anymore.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2115
Build 2123: arc lint + arc unit

Event Timeline

rpokala updated this revision to Diff 12278.Jan 14 2016, 1:46 AM

rpokala retitled this revision from to [PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl r287723 removed some cleanup from lagg(4), which leads to panics when changing configuration. Restore the spirit of the code which was removed. This issue has been refactored out of....

rpokala updated this object.

rpokala edited the test plan for this revision. (Show Details)

Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptJan 14 2016, 1:46 AM

Herald added a subscriber: imp. · View Herald Transcript

rpokala retitled this revision from [PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl r287723 removed some cleanup from lagg(4), which leads to panics when changing configuration. Restore the spirit of the code which was removed. This issue has been refactored out of... to [PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl.Jan 14 2016, 1:47 AM

rpokala updated this object.

rpokala edited edge metadata.

Cleanup suggested by @darius-dons.net.au : no need to unlock, when it is immediately locked again.

darius-dons.net.au accepted this revision.Jan 14 2016, 2:45 AM

darius-dons.net.au added a reviewer: darius-dons.net.au.

This revision is now accepted and ready to land.Jan 14 2016, 2:45 AM

Upon further examination, we discovered that some detach routines do
LAGG_WUNLOCK() and some don't. To minimize changes, leave the locking as-is,
and only do the NULLing.

This revision now requires review to proceed.Jan 14 2016, 11:38 PM

rpokala edited the test plan for this revision. (Show Details)Jan 14 2016, 11:54 PM

rpokala edited edge metadata.