Page MenuHomeFreeBSD
Differential D4929

[PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl
ClosedPublic
Actions

Authored by rpokala on Jan 14 2016, 1:46 AM.
Tags
None
Referenced Files
F82196110: D4929.id12279.diff
Fri, Apr 26, 9:00 AM
F82196010: D4929.id12278.diff
Fri, Apr 26, 8:59 AM
F82195997: D4929.id12334.diff
Fri, Apr 26, 8:59 AM
F82195993: D4929.id.diff
Fri, Apr 26, 8:59 AM
F82195988: D4929.id12340.diff
Fri, Apr 26, 8:59 AM
F82161138: D4929.diff
Fri, Apr 26, 1:56 AM
F82124696: D4929.id12278.diff
Thu, Apr 25, 6:47 PM
Unknown Object (File)
Thu, Apr 25, 5:16 AM
View All 89 Files
Subscribers
hiren
hrs
imp
jhb

Details

Reviewers
hiren
darius-dons.net.au
Group Reviewers
Contributor Reviewers (ports)
Commits
rS294070: [PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl
Summary

r287723 removed some cleanup from lagg(4), which leads to panics when
changing configuration. Restore the spirit of the code which was removed.
This issue has been refactored out of existence in -HEAD, so this patch is
directly against stable/10.

Test Plan

Create and destroy lagg, add and remove ports, switch laggprotos; used to panic, doesn't anymore.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rpokala updated this revision to Diff 12278.Jan 14 2016, 1:46 AM
rpokala retitled this revision from to [PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl r287723 removed some cleanup from lagg(4), which leads to panics when changing configuration. Restore the spirit of the code which was removed. This issue has been refactored out of....
rpokala updated this object.
rpokala edited the test plan for this revision. (Show Details)
Herald added a reviewer: Contributor Reviewers (ports). · View Herald TranscriptJan 14 2016, 1:46 AM
Herald added a subscriber: imp. · View Herald Transcript
rpokala retitled this revision from [PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl r287723 removed some cleanup from lagg(4), which leads to panics when changing configuration. Restore the spirit of the code which was removed. This issue has been refactored out of... to [PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl.Jan 14 2016, 1:47 AM
rpokala updated this object.
rpokala edited edge metadata.
rpokala updated this revision to Diff 12279.EditedJan 14 2016, 2:29 AM

Cleanup suggested by @darius-dons.net.au : no need to unlock, when it is immediately locked again.

darius-dons.net.au accepted this revision.Jan 14 2016, 2:45 AM
darius-dons.net.au added a reviewer: darius-dons.net.au.
This revision is now accepted and ready to land.Jan 14 2016, 2:45 AM
rpokala updated this revision to Diff 12334.Jan 14 2016, 11:38 PM
rpokala edited edge metadata.

Upon further examination, we discovered that some detach routines do
LAGG_WUNLOCK() and some don't. To minimize changes, leave the locking as-is,
and only do the NULLing.

This revision now requires review to proceed.Jan 14 2016, 11:38 PM
rpokala edited the test plan for this revision. (Show Details)Jan 14 2016, 11:54 PM
rpokala edited edge metadata.
hiren accepted this revision.Jan 15 2016, 12:19 AM
hiren added a reviewer: hiren.
hiren added subscribers: hrs, hiren.

looks okay to me. I am not sure what was the rationale for removing NULL initializations in the first place. May be @hrs could answer.

This revision is now accepted and ready to land.Jan 15 2016, 12:19 AM
jhb added a subscriber: jhb.Jan 15 2016, 4:04 AM

Approved, thanks.

Closed by commit rS294070: [PR 206219] Kernel panic from lagg_ioctl and lagg_port_ioctl (authored by rpokala). · Explain WhyJan 15 2016, 4:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
stable/
10/
sys/
net/
20 lines

Diff 12340

View Options

stable/10/sys/net/if_lagg.c

Loading...