pf: fix nat64 ICMP translation
ClosedPublic
Actions

Authored by kp on Mar 4 2025, 5:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 14, 3:41 PM

	Unknown Object (File)
	Sun, Nov 9, 11:58 PM

	Unknown Object (File)
	Thu, Nov 6, 3:16 AM

	Unknown Object (File)
	Oct 31 2025, 4:31 AM

	Unknown Object (File)
	Oct 29 2025, 8:56 AM

	Unknown Object (File)
	Oct 29 2025, 8:39 AM

	Unknown Object (File)
	Oct 29 2025, 8:31 AM

	Unknown Object (File)
	Oct 29 2025, 6:01 AM

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

None

Group Reviewers

pfsense
network

Commits

rG6e7f24e0a526: pf: fix nat64 ICMP translation

Summary

Fix more incorrect use of the iih pointer, this time causing corruption in nat64
translated ICMP error messages.
Extend the relevant test case to catch this bug.

Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Mar 4 2025, 5:39 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptMar 4 2025, 5:39 PM

kp requested review of this revision.Mar 4 2025, 5:39 PM

Harbormaster completed remote builds in B62753: Diff 151865.Mar 4 2025, 5:39 PM

ivy added a subscriber: ivy.Mar 5 2025, 2:14 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 5 2025, 9:39 AM

Closed by commit rG6e7f24e0a526: pf: fix nat64 ICMP translation (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rG6e7f24e0a526: pf: fix nat64 ICMP translation.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

4 lines

tests/

sys/

netpfil/

pf/

nat64.py

6 lines

Diff 151903

View Options

sys/netpfil/pf/pf.c