vmm: Emulate testb imm8,r/m8
ClosedPublic
Actions

Authored by jlduran on Mon, Mar 3, 7:14 AM.

Details

Reviewers

emaste
mp
scf
markj

Group Reviewers

bhyve

Commits

rG49a4838a0d94: vmm: Emulate testb imm8,r/m8

Summary

Add support for "testb imm8,r/m8" emulation.

PR: 261940
PR: 282852
Obtained from: Illumos (bug #14483)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jlduran created this revision.Mon, Mar 3, 7:14 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMon, Mar 3, 7:14 AM

jlduran requested review of this revision.Mon, Mar 3, 7:14 AM

Harbormaster completed remote builds in B62731: Diff 151767.Mon, Mar 3, 7:14 AM

markj added a subscriber: markj.Mon, Mar 3, 11:40 AM

markj added inline comments.

sys/amd64/vmm/vmm_instruction_emul.c
1312	Rather than duplicating the whole implementation, IMO it'd be neater to write: case 0xF6: size = 1; /* FALLTHROUGH */ case 0xF7: ...

driesm added a subscriber: driesm.Mon, Mar 3, 1:29 PM

Address suggestions:

Keep things "DRY"

Harbormaster completed remote builds in B62744: Diff 151818.Mon, Mar 3, 6:34 PM

emaste accepted this revision.Mon, Mar 3, 6:47 PM

This revision is now accepted and ready to land.Mon, Mar 3, 6:47 PM

jlduran edited the summary of this revision. (Show Details)Mon, Mar 3, 7:02 PM

markj accepted this revision as: markj.Mon, Mar 3, 11:19 PM

Closed by commit rG49a4838a0d94: vmm: Emulate testb imm8,r/m8 (authored by jlduran). · Explain WhyTue, Mar 4, 1:54 PM

This revision was automatically updated to reflect the committed changes.

jlduran added a commit: rG49a4838a0d94: vmm: Emulate testb imm8,r/m8.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

vmm/

vmm_instruction_emul.c

12 lines

Diff 151841

View Options

sys/amd64/vmm/vmm_instruction_emul.c

vmm: Emulate testb imm8,r/m8ClosedPublicActions