Page MenuHomeFreeBSD

vmm: Emulate testb imm8,r/m8
ClosedPublic

Authored by jlduran on Mar 3 2025, 7:14 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 10:04 PM
Unknown Object (File)
Tue, Sep 30, 4:48 PM
Unknown Object (File)
Fri, Sep 26, 5:26 PM
Unknown Object (File)
Wed, Sep 24, 1:44 AM
Unknown Object (File)
Fri, Sep 19, 2:33 AM
Unknown Object (File)
Fri, Sep 19, 1:40 AM
Unknown Object (File)
Sep 13 2025, 7:29 PM
Unknown Object (File)
Sep 11 2025, 4:21 PM

Details

Summary

Add support for "testb imm8,r/m8" emulation.

PR: 261940
PR: 282852
Obtained from: Illumos (bug #14483)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
sys/amd64/vmm/vmm_instruction_emul.c
1312

Rather than duplicating the whole implementation, IMO it'd be neater to write:

case 0xF6:
    size = 1;
    /* FALLTHROUGH */
case 0xF7:
    ...
jlduran marked an inline comment as done.

Address suggestions:

  • Keep things "DRY"
This revision is now accepted and ready to land.Mar 3 2025, 6:47 PM
This revision was automatically updated to reflect the committed changes.