Differential D49142

inpcb: inline in_pcbconnect_setup() into in_pcbconnect()
ClosedPublic
Actions

Authored by glebius on Feb 26 2025, 9:06 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 27, 5:27 AM

	Unknown Object (File)
	Wed, Sep 17, 5:23 PM

	Unknown Object (File)
	Aug 31 2025, 6:51 AM

	Unknown Object (File)
	Aug 26 2025, 12:39 PM

	Unknown Object (File)
	Aug 23 2025, 1:17 AM

	Unknown Object (File)
	Aug 22 2025, 4:30 PM

	Unknown Object (File)
	Aug 15 2025, 12:02 AM

	Unknown Object (File)
	Jun 29 2025, 12:25 AM

View All 35 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG2af953b132ee: inpcb: inline in_pcbconnect_setup() into in_pcbconnect()

Summary

The separation had been done back in 5200e00e7266 for the purposes of
removing a true temporary connect of an unconnected UDP socket that does
sendto(2) in 90162a4e87f0. Now, with 69c05f428714 in place, the
separation is no longer needed. There should be no functional change.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.Feb 26 2025, 9:06 PM

Herald added subscribers: melifaro, imp. · View Herald TranscriptFeb 26 2025, 9:06 PM

glebius requested review of this revision.Feb 26 2025, 9:06 PM

Harbormaster completed remote builds in B62642: Diff 151535.Feb 26 2025, 9:06 PM

glebius added a child revision: D49150: inpcb: fix a panic with SO_REUSEPORT_LB + connect(2) misuse.Feb 27 2025, 4:10 AM

markj accepted this revision as: markj.Mar 3 2025, 8:06 AM

This revision is now accepted and ready to land.Mar 3 2025, 8:06 AM

Closed by commit rG2af953b132ee: inpcb: inline in_pcbconnect_setup() into in_pcbconnect() (authored by glebius). · Explain WhyMar 7 2025, 7:01 AM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG2af953b132ee: inpcb: inline in_pcbconnect_setup() into in_pcbconnect().

Revision Contents
Changeset List

Path

Size

sys/

netinet/

2 lines

229 lines

Diff 152001

sys/netinet/in_pcb.h

Loading...

sys/netinet/in_pcb.c

Loading...