Page MenuHomeFreeBSD

net80211: crypto: ccmp: simplify and style(9)
ClosedPublic

Authored by bz on Feb 19 2025, 12:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 25, 8:46 PM
Unknown Object (File)
Sat, Sep 20, 9:32 PM
Unknown Object (File)
Thu, Sep 18, 7:35 PM
Unknown Object (File)
Sep 15 2025, 6:24 AM
Unknown Object (File)
Sep 9 2025, 9:06 AM
Unknown Object (File)
Sep 4 2025, 1:52 AM
Unknown Object (File)
Sep 3 2025, 3:23 AM
Unknown Object (File)
Aug 31 2025, 6:21 AM

Details

Summary

Add checks for booleaness of flag tests.
If there is no need for double negated checks simplify them.
This all makes the conditions a lot easier to read.

No functional changes.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested review of this revision.Feb 19 2025, 12:32 PM
emaste added a subscriber: emaste.

๐Ÿ‘ from De Morgan.

Maybe make the subject "simplify and style(9)", at first glance I was looking for another change in the first one other than just adding != 0

This revision is now accepted and ready to land.Feb 19 2025, 1:43 PM

๐Ÿ‘ from De Morgan.

Maybe make the subject "simplify and style(9)", at first glance I was looking for another change in the first one other than just adding != 0

Will do. Thanks.

bz retitled this revision from net80211: crypto: ccmp: simplify checks to net80211: crypto: ccmp: simplify and style(9).Feb 19 2025, 1:57 PM
This revision was automatically updated to reflect the committed changes.