socket: Add an option to retrieve a socket's FIB number
ClosedPublic
Actions

Authored by markj on Feb 4 2025, 5:11 PM.

Details

Reviewers

Group Reviewers

Commits

rGb0f2df45e7a6: socket: Add an option to retrieve a socket's FIB number
rGee951eb59f21: socket: Add an option to retrieve a socket's FIB number

Summary

The SO_SETFIB option can be used to set a socket's FIB number, but there
is no way to retrieve it. Rename SO_SETFIB to SO_FIB and implement a
handler for it for getsockopt(2).

Sponsored by: Klara, Inc.
Sponsored by: Stormshield

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62243
Build 59127: arc lint + arc unit

Event Timeline

markj created this revision.Feb 4 2025, 5:11 PM

Herald added subscribers: olce, glebius, imp. · View Herald TranscriptFeb 4 2025, 5:11 PM

markj requested review of this revision.Feb 4 2025, 5:11 PM

Harbormaster completed remote builds in B62243: Diff 150477.Feb 4 2025, 5:12 PM

markj added a child revision: D48835: tools: Add a small program to demonstrate FIB handling in bind(2).Feb 4 2025, 5:13 PM

If we move the fib to pcb would we be able to preserve this API? Of course it would start fail on sockets where FIB doesn't make any sense. But would we be able to preserve for meaningful sockets?

This revision is now accepted and ready to land.Feb 4 2025, 7:04 PM

In D48834#1113973, @glebius wrote:

If we move the fib to pcb would we be able to preserve this API? Of course it would start fail on sockets where FIB doesn't make any sense. But would we be able to preserve for meaningful sockets?

Yes, the handler could be moved to the protocol layer, like I did for setsockopt(SO_SETFIB) in D48666.

Closed by commit rGee951eb59f21: socket: Add an option to retrieve a socket's FIB number (authored by markj). · Explain WhyFeb 6 2025, 4:28 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGee951eb59f21: socket: Add an option to retrieve a socket's FIB number.

markj added a commit: rGb0f2df45e7a6: socket: Add an option to retrieve a socket's FIB number.Feb 21 2025, 1:57 AM

Herald added a subscriber: ziaee. · View Herald TranscriptFeb 21 2025, 1:57 AM