Bug 284503: Delete patch for fontmanager/freetypeScaler.c

[haraldei_anduin.net]

Summary

The patch causes a load failure when trying to load graphical java programs,
because it created a hard dependency on libfontconfig.so from
libfontmanager.so. This should be handled by the jdk itself by dynamically
loading fontconfig if it's needed.

Test Plan

Run various graphical java programs and check that font rendering works as it
should.

Be sure to test on both old HD as well as Hi-DPI displays.

[jrm]

Should the patch be removed from other JDK ports as well?

jrm@ser /usr/ports/java [main|✔] % fd patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c
openjdk11/files/patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c
openjdk17/files/patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c
openjdk18/files/patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c
openjdk19/files/patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c
openjdk20/files/patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c
openjdk21/files/patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c
openjdk22/files/patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c
openjdk23/files/patch-src_java.desktop_share_native_libfontmanager_freetypeScaler.c

[haraldei_anduin.net]

In D48806#1113261, @jrm wrote:

Should the patch be removed from other JDK ports as well?

I don't know. If we do that, we should also remove the patch that adds the link to libfontconfig as well. I have not analyzed the previous OpenJDK versions, though, so I do not know if that patch was necessary at some point, and if so, when it did become necessary. I think I'd have to go through each port and check, but I don't think that's a good use of my time right now.

[jrm]

Sounds good. You also need to bump PORTREVSION.

[haraldei_anduin.net]

In D48806#1113263, @jrm wrote:

Sounds good. You also need to bump PORTREVSION.

Thanks, was wondering about that :)

[haraldei_anduin.net]

Bump PORTREVISION

[emaste]

It looks like this originally came from PR 215636 in an older OpenJDK
CC @dmgk

[freebsd.68fba_nospam.spacesurfer.com]

I can confirm that removing this patch fixes the issue for java swing apps running with openjdk23 on my desktop

[haraldei_anduin.net]

Anything missing for this to be merged?