aio_kqueue_test: Fix CID 1558429

[dab]

Summary

Fix a Coverity error in the aio_kqueue_test that could theoretically
(but probably not realistically) cause over-indexing an array.

Test Plan

Ran test on local system; passed.

[dab]

Typo correction

[asomers]

I think this is OK. But it would also be fine just to put an assert(j < max_queue_per_proc before the array dereference.

[dab]

In D48328#1102276, @asomers wrote:

I think this is OK. But it would also be fine just to put an assert(j < max_queue_per_proc before the array dereference.

That was actually my first inclination, but didn't know if it was better to have the explicit message and let the test fail gracefully rather than have it abort on an assert.
Doing an assert would certainly be more straightforward and perhaps more clearly indicate that this is a scenario that should not ever happen.
I think I'll take your suggestion and revise this to use the assert method.

[dab]

Change to using an assert

[asomers]

This LGTM. Too bad Coverity can't figure it out for itself.

[vangyzen]

Coverity often surprises me, in both cleverness and ignorance. I suppose the same can be said of all software, and indeed, of most human pursuits.